From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9AEC3A0679 for ; Mon, 29 Apr 2019 18:24:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 734E95F62; Mon, 29 Apr 2019 18:24:40 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 4F29358CB for ; Mon, 29 Apr 2019 18:24:38 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id o5so5293767pls.12 for ; Mon, 29 Apr 2019 09:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=18KYs0FmkTVzK67dWIvlVcWaRHZX/PKEhY8VAKuCK10=; b=ZVCu4LHkzfSeHKVvLYe42yJaNY1CHVTqTkZgFm9JSv1V6NeIUdrgUezmVgCJu5SY4f FdQ17u4gfyevIwj9GkD6Iq1vVHZvw7XbDOrQTSvrfz91g7QPGKi9aFiuHtJLVjxE46TU OLo4r1E15T6GTmyPde+m239Af5Co728KUhI1lSkM81PqLi7iZ1wo+RDxeZcMtloqW2+p WYmByLAv9b/ZYVZ5urzgwOpG3O0Vg3JY49RqikguEqSqrr33k15dpr3ygmk6/1LlTcDE q05st54Xv73vKrFXd9HdhldeLSO9TCiP3DanaGM1MjjQ/FJBk2W0c2qVWp2nL50kQ90+ jVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=18KYs0FmkTVzK67dWIvlVcWaRHZX/PKEhY8VAKuCK10=; b=QfDUhkH1WkA6olw8gYm2rEtq3WH0va2ciukergS4PeNAUmDfbt0GxxkIG5IXa5Qbdw nXEfBUT79iCOIhqWcCvX93xmKh36SPtOaY+o+z5FQ3M029MVOfsa0LjH9P4A+fTWMxT8 QMb16OSyEUtVTKhhP8PwlffcapViLMLNxv4xX90r/H+wEa27FDGGwHyQamdOPe9Pet6d XaT0vMr7sEHuv8i/w0W8PX3MA4ZuuB6ZOcG6uPanIYufB5TuvXbC1Om27jWjRD/yM743 fBuIIb9dQMjfQhcGFiIZpiolCv8nBU5Fh//5shIqijgokZFlTXxIQZ/CFddwj7a98VMP WGeQ== X-Gm-Message-State: APjAAAV0tbZWmkCe5U7REaNxnkOr3Bm7xywdLhXpxkC03sJYZtiMsA0h EzVX19kXTmcLuy3kUwXexnzy+w== X-Google-Smtp-Source: APXvYqzSbE5slOqfTqZ88BP0Q3VsPZ5VxhBqOSpA0Ke5Tb/snDLBoSqC67+6YTZsGldHaQF/LSfwCw== X-Received: by 2002:a17:902:da4:: with SMTP id 33mr60895685plv.20.1556555077482; Mon, 29 Apr 2019 09:24:37 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b20sm16770287pff.118.2019.04.29.09.24.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 09:24:37 -0700 (PDT) Date: Mon, 29 Apr 2019 09:24:30 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Arnon Warshavsky , dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ranjit.menon@intel.com, anand.rawat@intel.com, pallavi.kadam@intel.com, harini.ramakrishnan@microsoft.com, cathal.ohare@intel.com, arnonw@qwilt.com Message-ID: <20190429092430.4e71a9ab@hermes.lan> In-Reply-To: References: <1556463528-22853-1-git-send-email-arnon@qwilt.com> <20190428092357.66ae2b80@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190429162430.ItkxyTw88SDiXZ1BFELOxSCrr1Cj2p-0QwFRTNmxOss@z> On Mon, 29 Apr 2019 10:28:36 +0100 Ferruh Yigit wrote: > > > > > >> +* kni: Modify function return value for the sake of removing rte_panic > >> + from the init sequence in version 19.08. > >> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace > >> + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)`` > >> + to return ``int`` > > > > This is not a public API really so no deprecation needed. > > It is just an include file used internally by library and the driver. > > This does introduce the possibility of kernel/library version mismatch. You might want to add a magic number to shared data structure.