[dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

For the purpose of removing instances of rte_panic
from the init sequence, some void functions need to change
to return an error code.The planned modifications of 19.08
require to change one eal function and one kni function.

Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
---
 doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c2..c4ab9a2 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -31,6 +31,12 @@ Deprecation Notices
 
     + ``rte_eal_devargs_type_count``
 
+* eal: Modify function return value for the sake of removing rte_panic
+       from the init sequence in version 19.08.
+  - In ``lib/librte_eal/common/eal_thread.h`` replace
+    ``void eal_thread_init_master(unsigned lcore_id)``
+    to return ``int``
+
 * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
   have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
   functions.  The due date for the removal targets DPDK 20.02.
@@ -65,6 +71,12 @@ Deprecation Notices
   kernel modules in DPDK. As a result users won't be able to use ``ethtool``
   via ``igb`` & ``ixgbe`` anymore.
 
+* kni: Modify function return value for the sake of removing rte_panic
+       from the init sequence in version 19.08.
+  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
+    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
+    to return ``int``
+
 * cryptodev: New member in ``rte_cryptodev_config`` to allow applications to
   disable features supported by the crypto device. Only the following features
   would be allowed to be disabled this way,
-- 
1.8.3.1

[dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

For the purpose of removing instances of rte_panic
from the init sequence, some void functions need to change
to return an error code.The planned modifications of 19.08
require to change one eal function and one kni function.

Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
---
 doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c2..c4ab9a2 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -31,6 +31,12 @@ Deprecation Notices
 
     + ``rte_eal_devargs_type_count``
 
+* eal: Modify function return value for the sake of removing rte_panic
+       from the init sequence in version 19.08.
+  - In ``lib/librte_eal/common/eal_thread.h`` replace
+    ``void eal_thread_init_master(unsigned lcore_id)``
+    to return ``int``
+
 * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
   have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
   functions.  The due date for the removal targets DPDK 20.02.
@@ -65,6 +71,12 @@ Deprecation Notices
   kernel modules in DPDK. As a result users won't be able to use ``ethtool``
   via ``igb`` & ``ixgbe`` anymore.
 
+* kni: Modify function return value for the sake of removing rte_panic
+       from the init sequence in version 19.08.
+  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
+    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
+    to return ``int``
+
 * cryptodev: New member in ``rte_cryptodev_config`` to allow applications to
   disable features supported by the crypto device. Only the following features
   would be allowed to be disabled this way,
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Stephen Hemminger]

On Sun, 28 Apr 2019 17:58:48 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:

These deprecation notices are unnecessary. These are not public API's.

> +* eal: Modify function return value for the sake of removing rte_panic
> +       from the init sequence in version 19.08.
> +  - In ``lib/librte_eal/common/eal_thread.h`` replace
> +    ``void eal_thread_init_master(unsigned lcore_id)``
> +    to return ``int``

This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API.


> +* kni: Modify function return value for the sake of removing rte_panic
> +       from the init sequence in version 19.08.
> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
> +    to return ``int``

This is not a public API really so no deprecation needed.
It is just an include file used internally by library and the driver.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Stephen Hemminger]

On Sun, 28 Apr 2019 17:58:48 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:

These deprecation notices are unnecessary. These are not public API's.

> +* eal: Modify function return value for the sake of removing rte_panic
> +       from the init sequence in version 19.08.
> +  - In ``lib/librte_eal/common/eal_thread.h`` replace
> +    ``void eal_thread_init_master(unsigned lcore_id)``
> +    to return ``int``

This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API.


> +* kni: Modify function return value for the sake of removing rte_panic
> +       from the init sequence in version 19.08.
> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
> +    to return ``int``

This is not a public API really so no deprecation needed.
It is just an include file used internally by library and the driver.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Ferruh Yigit]

On 4/28/2019 5:23 PM, Stephen Hemminger wrote:
> On Sun, 28 Apr 2019 17:58:48 +0300
> Arnon Warshavsky <arnon@qwilt.com> wrote:
> 
> These deprecation notices are unnecessary. These are not public API's.

+1

> 
>> +* eal: Modify function return value for the sake of removing rte_panic
>> +       from the init sequence in version 19.08.
>> +  - In ``lib/librte_eal/common/eal_thread.h`` replace
>> +    ``void eal_thread_init_master(unsigned lcore_id)``
>> +    to return ``int``
> 
> This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API.
> 
> 
>> +* kni: Modify function return value for the sake of removing rte_panic
>> +       from the init sequence in version 19.08.
>> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
>> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
>> +    to return ``int``
> 
> This is not a public API really so no deprecation needed.
> It is just an include file used internally by library and the driver.
> 

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Ferruh Yigit]

On 4/28/2019 5:23 PM, Stephen Hemminger wrote:
> On Sun, 28 Apr 2019 17:58:48 +0300
> Arnon Warshavsky <arnon@qwilt.com> wrote:
> 
> These deprecation notices are unnecessary. These are not public API's.

+1

> 
>> +* eal: Modify function return value for the sake of removing rte_panic
>> +       from the init sequence in version 19.08.
>> +  - In ``lib/librte_eal/common/eal_thread.h`` replace
>> +    ``void eal_thread_init_master(unsigned lcore_id)``
>> +    to return ``int``
> 
> This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API.
> 
> 
>> +* kni: Modify function return value for the sake of removing rte_panic
>> +       from the init sequence in version 19.08.
>> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
>> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
>> +    to return ``int``
> 
> This is not a public API really so no deprecation needed.
> It is just an include file used internally by library and the driver.
> 

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Stephen Hemminger]

On Mon, 29 Apr 2019 10:28:36 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> > 
> >   
> >> +* kni: Modify function return value for the sake of removing rte_panic
> >> +       from the init sequence in version 19.08.
> >> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
> >> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
> >> +    to return ``int``  
> > 
> > This is not a public API really so no deprecation needed.
> > It is just an include file used internally by library and the driver.
> >   

This does introduce the possibility of kernel/library version mismatch.
You might want to add a magic number to shared data structure.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Stephen Hemminger]

On Mon, 29 Apr 2019 10:28:36 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> > 
> >   
> >> +* kni: Modify function return value for the sake of removing rte_panic
> >> +       from the init sequence in version 19.08.
> >> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
> >> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
> >> +    to return ``int``  
> > 
> > This is not a public API really so no deprecation needed.
> > It is just an include file used internally by library and the driver.
> >   

This does introduce the possibility of kernel/library version mismatch.
You might want to add a magic number to shared data structure.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Ferruh Yigit]

On 4/29/2019 5:24 PM, Stephen Hemminger wrote:
> On Mon, 29 Apr 2019 10:28:36 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>>>
>>>   
>>>> +* kni: Modify function return value for the sake of removing rte_panic
>>>> +       from the init sequence in version 19.08.
>>>> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
>>>> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
>>>> +    to return ``int``  
>>>
>>> This is not a public API really so no deprecation needed.
>>> It is just an include file used internally by library and the driver.
>>>   
> 
> This does introduce the possibility of kernel/library version mismatch.
> You might want to add a magic number to shared data structure.
> 

Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
perhaps it would be a problem if the content of the fifo changed but it is not
the case.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Ferruh Yigit]

On 4/29/2019 5:24 PM, Stephen Hemminger wrote:
> On Mon, 29 Apr 2019 10:28:36 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>>>
>>>   
>>>> +* kni: Modify function return value for the sake of removing rte_panic
>>>> +       from the init sequence in version 19.08.
>>>> +  - In ``lib/librte_kni/rte_kni_fifo.h`` replace
>>>> +    ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
>>>> +    to return ``int``  
>>>
>>> This is not a public API really so no deprecation needed.
>>> It is just an include file used internally by library and the driver.
>>>   
> 
> This does introduce the possibility of kernel/library version mismatch.
> You might want to add a magic number to shared data structure.
> 

Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
perhaps it would be a problem if the content of the fifo changed but it is not
the case.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

>
>
> Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
> perhaps it would be a problem if the content of the fifo changed but it is
> not
> the case.
>

Should I move this patch to deferred or reject?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

>
>
> Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
> perhaps it would be a problem if the content of the fifo changed but it is
> not
> the case.
>

Should I move this patch to deferred or reject?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Thomas Monjalon]

07/05/2019 11:57, Arnon Warshavsky:
> >
> >
> > Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
> > perhaps it would be a problem if the content of the fifo changed but it is
> > not
> > the case.
> >
> 
> Should I move this patch to deferred or reject?

It can be set to "rejected".

I am preparing a deprecation notice for rte_eal_remote_launch
and rte_metrics_init.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Thomas Monjalon]

07/05/2019 11:57, Arnon Warshavsky:
> >
> >
> > Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
> > perhaps it would be a problem if the content of the fifo changed but it is
> > not
> > the case.
> >
> 
> Should I move this patch to deferred or reject?

It can be set to "rejected".

I am preparing a deprecation notice for rte_eal_remote_launch
and rte_metrics_init.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

>
>
>
> I am preparing a deprecation notice for rte_eal_remote_launch
> and rte_metrics_init.
>
>
> hmm, I followed panic and not exit, so missed rte_metrics_init.
rte_eal_remote_launch currently returns int. what deprecation goes there?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Arnon Warshavsky]

>
>
>
> I am preparing a deprecation notice for rte_eal_remote_launch
> and rte_metrics_init.
>
>
> hmm, I followed panic and not exit, so missed rte_metrics_init.
rte_eal_remote_launch currently returns int. what deprecation goes there?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Thomas Monjalon]

08/05/2019 22:22, Arnon Warshavsky:
> > I am preparing a deprecation notice for rte_eal_remote_launch
> > and rte_metrics_init.
> >
> hmm, I followed panic and not exit, so missed rte_metrics_init.
> rte_eal_remote_launch currently returns int. what deprecation goes there?

We probably need to add a new error code for rte_eal_remote_launch.
It is just a doxygen change, but it is part of the API.

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

[Thomas Monjalon]

08/05/2019 22:22, Arnon Warshavsky:
> > I am preparing a deprecation notice for rte_eal_remote_launch
> > and rte_metrics_init.
> >
> hmm, I followed panic and not exit, so missed rte_metrics_init.
> rte_eal_remote_launch currently returns int. what deprecation goes there?

We probably need to add a new error code for rte_eal_remote_launch.
It is just a doxygen change, but it is part of the API.