From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 94325A0679 for ; Tue, 30 Apr 2019 09:58:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E23B5B12; Tue, 30 Apr 2019 09:58:49 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EA889397D for ; Tue, 30 Apr 2019 09:58:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7780021C08; Tue, 30 Apr 2019 03:58:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 30 Apr 2019 03:58:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=RM0HdmKTfE0sdXeeyTQ4LlJBMaZoNxsdUyxn3ZcGX3o=; b=p5PQzPlu3xAd Tz2H6IZdF5rr57icMGnHN+Vs9VGNFV/YY5w8p8bANXaaex2YmRn+EWT+QyaWWr3Q RdYGnbuXBDtPvmmooeik8glxkotUm+uSH9LyozlmZ/myuBDN3Di9iqjG/q7PG9M/ kFnmWksRMmtO9s/V2jZuXqxnkppofA8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RM0HdmKTfE0sdXeeyTQ4LlJBMaZoNxsdUyxn3ZcGX 3o=; b=EuAQDyQPTLZtReoGjanjkjBpoMHe+xw47IBf0b4gKit0TMPHxYoK/HkNZ xOgp3e2tvz+lPOXEZ35dM+15hUzI7ZkqUMtldh8ah250Z2V+7LLsktVt9B9LvICZ Na/qRErM4lo1PZiuqw3kLaDczjfNDamt5NxJSI4QaKfd6GabNHMCvPm9Ano6Pd81 xpNrbizZyhOd0U0ZfCTrlpelmONi0ZQO3WU5SmWIjUqgc442sX9Kje/jlC8FGF8A fwOCs0NFj80Qco8OxXJ49GNhImO8kzGGfA93xbR48uPTzz0zpr2x+BhX2SIquMJl zzRn5T74DWd08kehzc5o44f/GKLBw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieefgdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A12A103CE; Tue, 30 Apr 2019 03:58:44 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli Cc: "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "stephen@networkplumber.org" , "paulmck@linux.ibm.com" , "marko.kovacevic@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , Malvika Gupta , nd Date: Tue, 30 Apr 2019 09:58:42 +0200 Message-ID: <103798442.BsfX60FqQl@xps> In-Reply-To: References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <4536165.YyUABP5Aq1@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190430075842.VCcyCGCTwrVabzJPYxviPK4MJZ5lUUp2QQddAbQQ4rw@z> 30/04/2019 06:20, Honnappa Nagarahalli: > > > > Please, could you check details like alignment or alphabetical sorting? > I don't see any alignment issues (there is mixed use of tabs and spaces in this file, will use the same). > > > Thanks > > > > 26/04/2019 06:39, Honnappa Nagarahalli: > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > @@ -111,6 +111,8 @@ test_sources = files('commands.c', > > > 'test_timer_racecond.c', > > > 'test_timer_secondary.c', > > > 'test_ticketlock.c', > > > + 'test_rcu_qsbr.c', > > > + 'test_rcu_qsbr_perf.c', > > > 'test_version.c', > > > 'virtual_pmd.c' > > > ) > > > @@ -137,7 +139,8 @@ test_deps = ['acl', > > > 'reorder', > > > 'ring', > > > 'stack', > > > - 'timer' > > > + 'timer', > > > + 'rcu' > > > ] > > > > > > # All test cases in fast_parallel_test_names list are parallel @@ > > > -176,6 +179,7 @@ fast_parallel_test_names = [ > > > 'ring_autotest', > > > 'ring_pmd_autotest', > > > 'rwlock_autotest', > > > + 'rcu_qsbr_autotest', > > > 'sched_autotest', > > > 'spinlock_autotest', > > > 'stack_autotest', > > > @@ -243,6 +247,7 @@ perf_test_names = [ > This list is not sorted, is it on purpose? If yes, are we supposed to be adding at the end of the list? It looks mostly sorted. I think you should insert rcu before red. > > > 'red_perf', > > > 'distributor_perf_autotest', > > > 'ring_pmd_perf_autotest', > > > + 'rcu_qsbr_perf_autotest', > > > 'pmd_perf_autotest', > > > 'stack_perf_autotest', > > > 'stack_nb_perf_autotest',