From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DE437A0679 for ; Tue, 30 Apr 2019 11:34:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A58835F1A; Tue, 30 Apr 2019 11:34:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7D8035B38 for ; Tue, 30 Apr 2019 11:34:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2019 02:34:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,413,1549958400"; d="scan'208";a="166211230" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113]) ([10.237.220.113]) by fmsmga002.fm.intel.com with ESMTP; 30 Apr 2019 02:34:46 -0700 To: "Varghese, Vipin" , "Suanming.Mou" , "dev@dpdk.org" References: <1556428025-49290-1-git-send-email-mousuanming@huawei.com> <1556595548-53745-1-git-send-email-mousuanming@huawei.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D33FA5F@BGSMSX101.gar.corp.intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 30 Apr 2019 10:34:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D33FA5F@BGSMSX101.gar.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190430093445.Ca3nZ6nVb9XnIXDjdr1TnBeTLGfFG1NEHyPMyKMAEGs@z> On 30-Apr-19 3:33 AM, Varghese, Vipin wrote: > Thanks for the patch work with rte_eal_alaram. But I am not able to find > > 1. the documentation update. > 2. cover letter. Why would a single patch need a cover letter? I don't think it's needed in this case. The commit message is enough. > 3. for signal SIGINT, set for ` rte_eal_alarm_cancel`. > > Can you share a new patch as v5 with these changes? > > Thanks > Vipin Varghese > -- Thanks, Anatoly