DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, kkanas@marvell.com, dev@dpdk.org
Cc: declan.doherty@intel.com, Chas Williams <chas3@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix test bonding MAC assignment
Date: Tue, 30 Apr 2019 12:25:54 +0100	[thread overview]
Message-ID: <d791f805-5ee7-5a73-dcf6-be756dab08a1@intel.com> (raw)
Message-ID: <20190430112554.NWpNDIzEq6wjUld4zOWx8nGptFVOXPLOvChPy0Eg504@z> (raw)
In-Reply-To: <c683c917-2af9-791c-02e9-22211801d6ef@gmail.com>

On 4/29/2019 5:45 PM, Chas Williams wrote:
> Seems fine.
> 
> Acked-by: Chas Williams <chas3@att.com>

Applied to dpdk-next-net/master, thanks.

> 
> On 4/29/19 10:56 AM, Ferruh Yigit wrote:
>> On 4/26/2019 11:30 PM, kkanas@marvell.com wrote:
>>> From: Krzysztof Kanas <kkanas@marvell.com>
>>>
>>> Fix test_set_bonded_port_initialization_mac_assignment so that it works
>>> after 're run' test_link_bonding.
>>>
>>> Fixes: f2ef6f21ee2e ("bond: fix mac assignment to slaves")
>>> Cc: declan.doherty@intel.com
>>>
>>> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>

Changed patch title as: "app/test: fix test bonding MAC assignment"

<...>

>>>   	/*
>>> -	 * 2. Add slave ethdevs to bonded device
>>> -	 */
>>> +	* 2. Add slave ethdevs to bonded device
>>> +	*/
>>>   	for (i = 0; i < BONDED_INIT_MAC_ASSIGNMENT_SLAVE_COUNT; i++) {
>>>   		TEST_ASSERT_SUCCESS(rte_eth_bond_slave_add(bonded_port_id,
>>>   				slave_port_ids[i]),
>>>   				"Failed to add slave (%d) to bonded port (%d).",
>>>   				slave_port_ids[i], bonded_port_id);
>>>   	}
>>> -
>>>   	slave_count = rte_eth_bond_slaves_get(bonded_port_id, slaves,
>>>   			RTE_MAX_ETHPORTS);

Removed these unrelated whitespace changes and did a few syntax update while
merging.

  parent reply	other threads:[~2019-04-30 11:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 22:30 kkanas
2019-04-26 22:30 ` kkanas
2019-04-29 14:56 ` Ferruh Yigit
2019-04-29 14:56   ` Ferruh Yigit
2019-04-29 16:45   ` Chas Williams
2019-04-29 16:45     ` Chas Williams
2019-04-30 11:25     ` Ferruh Yigit [this message]
2019-04-30 11:25       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d791f805-5ee7-5a73-dcf6-be756dab08a1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=kkanas@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).