From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 068FCA0679
	for <public@inbox.dpdk.org>; Tue, 30 Apr 2019 16:13:48 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BBAB35F1B;
	Tue, 30 Apr 2019 16:13:47 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id DBFA25B2C
 for <dev@dpdk.org>; Tue, 30 Apr 2019 16:13:45 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 30 Apr 2019 07:13:44 -0700
X-ExtLoop1: 1
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48])
 by orsmga002.jf.intel.com with SMTP; 30 Apr 2019 07:13:43 -0700
Received: by  (sSMTP sendmail emulation); Tue, 30 Apr 2019 15:13:42 +0100
Date: Tue, 30 Apr 2019 15:13:42 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Message-ID: <20190430141342.GA1795@bricha3-MOBL.ger.corp.intel.com>
References: <20190430140325.45537-1-bruce.richardson@intel.com>
 <20190430140325.45537-2-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190430140325.45537-2-bruce.richardson@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary
 meson version check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190430141342.v6oXXffSceQyIHyA-Du_5gzabJZPLro5B06wyOCMlL4@z>

On Tue, Apr 30, 2019 at 03:03:23PM +0100, Bruce Richardson wrote:
> The check for meson version 0.44 is not redundant since the minimum

"not", in this case, being used as a synonym for "now" :-)

> supported version for the project as a whole is 0.47.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  kernel/linux/meson.build | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
> index d751d939f..bf8f085b0 100644
> --- a/kernel/linux/meson.build
> +++ b/kernel/linux/meson.build
> @@ -7,13 +7,8 @@ WARN_CROSS_COMPILE='Need "kernel_dir" option for kmod compilation when cross-com
>  WARN_NO_HEADERS='Cannot compile kernel modules as requested - are kernel headers installed?'
>  
>  # if we are cross-compiling we need kernel_dir specified
> -# NOTE: warning() function only available from version 0.44 onwards
>  if get_option('kernel_dir') == '' and meson.is_cross_build()
> -	if meson.version().version_compare('>=0.44')
> -		warning(WARN_CROSS_COMPILE)
> -	else
> -		message('WARNING: ' + WARN_CROSS_COMPILE)
> -	endif
> +	warning(WARN_CROSS_COMPILE)
>  else
>  
>  	kernel_dir = get_option('kernel_dir')
> -- 
> 2.20.1
>