Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Wednesday, April 24, 2019 4:36 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; Mcnamara, John <john.mcnamara@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org; Lipiec, Herakliusz <herakliusz.lipiec@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [PATCH] doc: fix broken link in programmers guide lpm library
> references
> 
> Bugzilla ID: 235

The fix is good and should be applied.

However, if viewed strictly, that `Link text <https://url/>`_ syntax is only required if the link text and the url are different.

So in this case you could (or the original author) just use a simple url without any additional syntax.

However, better still would be if we did something like this to put the links inline in the text:

diff --git a/doc/guides/prog_guide/lpm_lib.rst b/doc/guides/prog_guide/lpm_lib.rst
index 99563a4..375e666 100644
--- a/doc/guides/prog_guide/lpm_lib.rst
+++ b/doc/guides/prog_guide/lpm_lib.rst
@@ -191,8 +191,10 @@ The LPM algorithm is used to implement Classless Inter-Domain Routing (CIDR) str
 References
 ~~~~~~~~~~
 
-*   RFC1519 Classless Inter-Domain Routing (CIDR): an Address Assignment and Aggregation Strategy,
-    `http://www.ietf.org/rfc/rfc1519 <http://www.ietf.org/rfc/rfc1519>`_
+* `RFC1519 <http://www.ietf.org/rfc/rfc1519>`_ Classless Inter-Domain Routing
+  (CIDR): an Address Assignment and Aggregation Strategy.
 
-*   Pankaj Gupta, Algorithms for Routing Lookups and Packet Classification, PhD Thesis, Stanford University,
-    2000  (`http://klamath.stanford.edu/~pankaj/thesis/ thesis_1sided.pdf <http://klamath.stanford.edu/~pankaj/thesis/%20thesis_1sided.pdf>`_ )
+
+* Pankaj Gupta, `Algorithms for Routing Lookups and Packet Classification
+  <http://klamath.stanford.edu/~pankaj/thesis/thesis_1sided.pdf>`_, PhD
+  Thesis, Stanford University, 2000.

However, the fix is better than a broken link so:

Acked-by: John McNamara <john.mcnamara@intel.com>