From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7A4DF2C23 for ; Wed, 1 May 2019 17:53:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2019 08:53:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,418,1549958400"; d="scan'208";a="139026096" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.222.236]) by orsmga008.jf.intel.com with ESMTP; 01 May 2019 08:53:40 -0700 From: Bruce Richardson To: pablo.de.lara.guarch@intel.com Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 1 May 2019 16:53:28 +0100 Message-Id: <20190501155329.50107-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190501155329.50107-1-bruce.richardson@intel.com> References: <20190501155329.50107-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 2/3] crypto/kasumi: fix dependency check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 15:53:42 -0000 The check for the kasumi library dependency did not check for the include file needed for compilation. It's also recommended when looking for a library to use the name without the lib prefix. Fixes: 2ec2d46c6255 ("crypto/kasumi: enable meson build") Signed-off-by: Bruce Richardson --- drivers/crypto/kasumi/meson.build | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/kasumi/meson.build b/drivers/crypto/kasumi/meson.build index 80f13cd24..0fa301740 100644 --- a/drivers/crypto/kasumi/meson.build +++ b/drivers/crypto/kasumi/meson.build @@ -1,13 +1,13 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -lib = cc.find_library('libsso_kasumi', required: false) -if not lib.found() +lib = cc.find_library('sso_kasumi', required: false) +if not lib.found() or not cc.has_header('sso_kasumi.h') build = false -else - ext_deps += lib + subdir_done() endif allow_experimental_apis = true +ext_deps += lib sources = files('rte_kasumi_pmd.c', 'rte_kasumi_pmd_ops.c') deps += ['bus_vdev'] -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 52BD2A0AC5 for ; Wed, 1 May 2019 17:53:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50DBD2F42; Wed, 1 May 2019 17:53:44 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7A4DF2C23 for ; Wed, 1 May 2019 17:53:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2019 08:53:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,418,1549958400"; d="scan'208";a="139026096" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.222.236]) by orsmga008.jf.intel.com with ESMTP; 01 May 2019 08:53:40 -0700 From: Bruce Richardson To: pablo.de.lara.guarch@intel.com Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 1 May 2019 16:53:28 +0100 Message-Id: <20190501155329.50107-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190501155329.50107-1-bruce.richardson@intel.com> References: <20190501155329.50107-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 2/3] crypto/kasumi: fix dependency check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190501155328.u9i9Q2Ck6wJeydZoUvYhdSmMSEPTizLHI2UeWOCEfSA@z> The check for the kasumi library dependency did not check for the include file needed for compilation. It's also recommended when looking for a library to use the name without the lib prefix. Fixes: 2ec2d46c6255 ("crypto/kasumi: enable meson build") Signed-off-by: Bruce Richardson --- drivers/crypto/kasumi/meson.build | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/kasumi/meson.build b/drivers/crypto/kasumi/meson.build index 80f13cd24..0fa301740 100644 --- a/drivers/crypto/kasumi/meson.build +++ b/drivers/crypto/kasumi/meson.build @@ -1,13 +1,13 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -lib = cc.find_library('libsso_kasumi', required: false) -if not lib.found() +lib = cc.find_library('sso_kasumi', required: false) +if not lib.found() or not cc.has_header('sso_kasumi.h') build = false -else - ext_deps += lib + subdir_done() endif allow_experimental_apis = true +ext_deps += lib sources = files('rte_kasumi_pmd.c', 'rte_kasumi_pmd_ops.c') deps += ['bus_vdev'] -- 2.21.0