DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 3/3] crypto/zuc: fix dependency check
Date: Wed,  1 May 2019 16:53:29 +0100	[thread overview]
Message-ID: <20190501155329.50107-4-bruce.richardson@intel.com> (raw)
Message-ID: <20190501155329.Ulb0M5mcMJmt9h_tVW8UgxP2AldNTEJvJYSwnNKY8R4@z> (raw)
In-Reply-To: <20190501155329.50107-1-bruce.richardson@intel.com>

The check for the zuc library dependency did not check for the include
file needed for compilation. It's also recommended when looking for a
library to use the name without the lib prefix.

Fixes: df1740a8db5f ("crypto/zuc: enable meson build")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/crypto/zuc/meson.build | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/zuc/meson.build b/drivers/crypto/zuc/meson.build
index 63f2a5298..fc2900244 100644
--- a/drivers/crypto/zuc/meson.build
+++ b/drivers/crypto/zuc/meson.build
@@ -1,13 +1,13 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Intel Corporation
 
-lib = cc.find_library('libsso_zuc', required: false)
-if not lib.found()
+lib = cc.find_library('sso_zuc', required: false)
+if not lib.found() or not cc.has_header('sso_zuc.h')
 	build = false
-else
-	ext_deps += lib
+	subdir_done()
 endif
 
 allow_experimental_apis = true
+ext_deps += lib
 sources = files('rte_zuc_pmd.c', 'rte_zuc_pmd_ops.c')
 deps += ['bus_vdev']
-- 
2.21.0


  parent reply	other threads:[~2019-05-01 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 15:53 [dpdk-dev] [PATCH 0/3] small fixes for crypto drivers Bruce Richardson
2019-05-01 15:53 ` Bruce Richardson
2019-05-01 15:53 ` [dpdk-dev] [PATCH 1/3] crypto/snow3g: add to meson build Bruce Richardson
2019-05-01 15:53   ` Bruce Richardson
2019-05-01 15:53 ` [dpdk-dev] [PATCH 2/3] crypto/kasumi: fix dependency check Bruce Richardson
2019-05-01 15:53   ` Bruce Richardson
2019-05-01 15:53 ` Bruce Richardson [this message]
2019-05-01 15:53   ` [dpdk-dev] [PATCH 3/3] crypto/zuc: " Bruce Richardson
2019-05-02  9:08 ` [dpdk-dev] [PATCH 0/3] small fixes for crypto drivers Thomas Monjalon
2019-05-02  9:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501155329.50107-4-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).