From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, shreyansh.jain@nxp.com
Subject: [dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer
Date: Wed, 1 May 2019 20:50:12 +0100 [thread overview]
Message-ID: <20190501195014.2938-3-bruce.richardson@intel.com> (raw)
Message-ID: <20190501195012.9tYU6bckR--86UMFT5TWrILPa7Gg8d6U8dwmMhFjP4Y@z> (raw)
In-Reply-To: <20190501195014.2938-1-bruce.richardson@intel.com>
Printing a null pointer with %s is flagged as a warning by GCC 9, and
should not be done. Replace the %s with the word "null" itself.
Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions")
Cc: shreyansh.jain@nxp.com
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/bus/fslmc/fslmc_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index eaa39a209..f6e66d22c 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -197,7 +197,7 @@ scan_one_fslmc_device(char *dev_name)
t_ptr = strtok(NULL, ".");
if (!t_ptr) {
- DPAA2_BUS_ERR("Incorrect device string observed (%s)", t_ptr);
+ DPAA2_BUS_ERR("Incorrect device string observed (null)");
goto cleanup;
}
--
2.21.0
next prev parent reply other threads:[~2019-05-01 19:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 19:50 [dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-01 19:50 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC " Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-02 12:20 ` David Marchand
2019-05-02 12:20 ` David Marchand
2019-05-01 19:50 ` Bruce Richardson [this message]
2019-05-01 19:50 ` [dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer Bruce Richardson
2019-05-02 12:20 ` David Marchand
2019-05-02 12:20 ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-02 12:22 ` David Marchand
2019-05-02 12:22 ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 4/4] raw/dpaa2_cmdif: " Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-02 12:24 ` David Marchand
2019-05-02 12:24 ` David Marchand
2019-05-02 12:18 ` [dpdk-dev] [PATCH 0/4] fix warnings with gcc " Thomas Monjalon
2019-05-02 12:18 ` Thomas Monjalon
2019-05-02 12:32 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-05-02 12:32 ` David Marchand
2019-05-02 13:24 ` Bruce Richardson
2019-05-02 13:24 ` Bruce Richardson
2019-05-02 13:32 ` David Marchand
2019-05-02 13:32 ` David Marchand
2019-05-02 13:46 ` Bruce Richardson
2019-05-02 13:46 ` Bruce Richardson
2019-05-02 13:53 ` David Marchand
2019-05-02 13:53 ` David Marchand
2019-05-02 14:04 ` Bruce Richardson
2019-05-02 14:04 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501195014.2938-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).