From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 40E07A0AC5 for ; Thu, 2 May 2019 10:04:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2634A29D2; Thu, 2 May 2019 10:04:09 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 79B762986 for ; Thu, 2 May 2019 10:04:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 01:04:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="154077489" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 02 May 2019 01:04:06 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 2 May 2019 01:04:05 -0700 Received: from bgsmsx104.gar.corp.intel.com (10.223.4.190) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 2 May 2019 01:04:05 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.217]) by BGSMSX104.gar.corp.intel.com ([169.254.5.147]) with mapi id 14.03.0415.000; Thu, 2 May 2019 13:34:03 +0530 From: "Varghese, Vipin" To: Suanming.Mou , "dev@dpdk.org" CC: "Burakov, Anatoly" Thread-Topic: [PATCH v6] app/pdump: add pudmp exits with primary support Thread-Index: AQHVAJXAD0r7+1vxC0GfwP43i0dBR6ZXeQrQ Date: Thu, 2 May 2019 08:04:02 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D340270@BGSMSX101.gar.corp.intel.com> References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> In-Reply-To: <1556774432-59147-1-git-send-email-mousuanming@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjIyYzRiNzItNjE1Yy00YzdlLWJhYmMtYjYxOGRiZTg0NTMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR3FDUllWVUdtNjN4MU95NDZPSVZaOU53QWtZcUlkU1BFUmpLNkJXclRIYm1ESFZmdk1NeXhBclpRdlJmWG9RXC8ifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502080402.YR_10YSRtlQlAv_sGIC2zXpF9-5fWewtqxL-mxUFT_A@z> Hi Suanming, snipped >=20 > /* true if x is a power of 2 */ > #define POWEROF2(x) ((((x)-1) & (x)) =3D=3D 0) @@ -413,6 +416,18 @@ stru= ct Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? > parse_val { } >=20 > static void > +monitor_primary(void *arg __rte_unused) { > + if (quit_signal) > + return; > + > + if (rte_eal_primary_proc_alive(NULL)) > + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, > NULL); > + else > + quit_signal =3D 1; > +} This is suggestion, why not omit else part with=20 ` if (rte_eal_primary_proc_alive(NULL)) { rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,NULL); return; } ` Snipped As suggested in v4 can you update the `pdump.rst` on the new behaviour? Thanks Vipin Varghese