From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0A44F5F16 for ; Thu, 2 May 2019 15:17:42 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:17:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="147662172" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga007.fm.intel.com with SMTP; 02 May 2019 06:17:39 -0700 Received: by (sSMTP sendmail emulation); Thu, 02 May 2019 14:17:38 +0100 Date: Thu, 2 May 2019 14:17:38 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Luca Boccassi , dev@dpdk.org Message-ID: <20190502131738.GA1980@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <181e25f512b11f6c691f58c2cfdf47a9322a5091.camel@debian.org> <20190426144838.GA26084@bsd12> <2551645.ic9nZLS4EI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2551645.ic9nZLS4EI@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 13:17:43 -0000 On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > 26/04/2019 16:56, Bruce Richardson: > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > > > > > +# > > > > > > > > rather > > > > > > > > than hacking our environment, just edit the .pc file prefix > > > > > > > > value > > > > > > > > +sed > > > > > > > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > > > > > > > > > > > > > What about just using meson's prefix option instead? Which is > > > > > > > how > > > > > > > it > > > > > > > would be used in a real use case > > > > > > > > > > > > I don't think that would fully work, as my understanding is that > > > > > > the > > > > > > prefix > > > > > > option would apply only to the /usr/local parts, but not to the > > > > > > kernel > > > > > > modules which would still try and install in /lib/. > > > > > > > > > > What about doing a meson configure -Denable_kmods=false before the > > > > > ninja install? The modules are not needed for that test anyway, > > > > > right? > > > > > Alternatively, the kernel src dir could be symlinked in the build > > > > > path, > > > > > and the kernel_dir option could be used > > > > > > > > > > I'm just worried that the test should be as "realistic" as > > > > > possible, to > > > > > avoid missing something > > > > > > > > Yes, I did think of that too, but it does mean doing another > > > > configuration > > > > run in meson, and possibly a rebuild too if the rte_build_config.h > > > > file > > > > changes. Therefore I decided to use DESTDIR for the sake of speed > > > > here. I > > > > assumed there would be a pkg-config variable to adjust the output > > > > paths > > > > based on a sysroot, but couldn't find a suitable one. > [...] > > > > > > There actually is a pkg-config binary option, I just tried and it works > > > (it seems to be disabled by default on Debian and derivatives): -- > > > define-prefix > > > > > Any cmdline options to pkg-config don't solve the problem here as it means > > that the makefiles for any app need to be modified to use all those. > > It looks to be a good solution. > Being able to update the DPDK install directory when building > an application should be a mandatory requirement. > I suggest to wrap the call to pkg-config so we can have this ability. > I would have expected that this issue has already been solved for packagers. I was surprised that I couldn't find an easy way to do so. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7839FA0AC5 for ; Thu, 2 May 2019 15:17:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 425485F19; Thu, 2 May 2019 15:17:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0A44F5F16 for ; Thu, 2 May 2019 15:17:42 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:17:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="147662172" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga007.fm.intel.com with SMTP; 02 May 2019 06:17:39 -0700 Received: by (sSMTP sendmail emulation); Thu, 02 May 2019 14:17:38 +0100 Date: Thu, 2 May 2019 14:17:38 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Luca Boccassi , dev@dpdk.org Message-ID: <20190502131738.GA1980@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <181e25f512b11f6c691f58c2cfdf47a9322a5091.camel@debian.org> <20190426144838.GA26084@bsd12> <2551645.ic9nZLS4EI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <2551645.ic9nZLS4EI@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502131738.SB8RY5Kq9I-qH5yFMnKbB9MUb51MIzNEfZvEx5eJc-I@z> On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > 26/04/2019 16:56, Bruce Richardson: > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > > > > > +# > > > > > > > > rather > > > > > > > > than hacking our environment, just edit the .pc file prefix > > > > > > > > value > > > > > > > > +sed > > > > > > > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > > > > > > > > > > > > > What about just using meson's prefix option instead? Which is > > > > > > > how > > > > > > > it > > > > > > > would be used in a real use case > > > > > > > > > > > > I don't think that would fully work, as my understanding is that > > > > > > the > > > > > > prefix > > > > > > option would apply only to the /usr/local parts, but not to the > > > > > > kernel > > > > > > modules which would still try and install in /lib/. > > > > > > > > > > What about doing a meson configure -Denable_kmods=false before the > > > > > ninja install? The modules are not needed for that test anyway, > > > > > right? > > > > > Alternatively, the kernel src dir could be symlinked in the build > > > > > path, > > > > > and the kernel_dir option could be used > > > > > > > > > > I'm just worried that the test should be as "realistic" as > > > > > possible, to > > > > > avoid missing something > > > > > > > > Yes, I did think of that too, but it does mean doing another > > > > configuration > > > > run in meson, and possibly a rebuild too if the rte_build_config.h > > > > file > > > > changes. Therefore I decided to use DESTDIR for the sake of speed > > > > here. I > > > > assumed there would be a pkg-config variable to adjust the output > > > > paths > > > > based on a sysroot, but couldn't find a suitable one. > [...] > > > > > > There actually is a pkg-config binary option, I just tried and it works > > > (it seems to be disabled by default on Debian and derivatives): -- > > > define-prefix > > > > > Any cmdline options to pkg-config don't solve the problem here as it means > > that the makefiles for any app need to be modified to use all those. > > It looks to be a good solution. > Being able to update the DPDK install directory when building > an application should be a mandatory requirement. > I suggest to wrap the call to pkg-config so we can have this ability. > I would have expected that this issue has already been solved for packagers. I was surprised that I couldn't find an easy way to do so.