From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BC872A0AC5 for ; Thu, 2 May 2019 15:21:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9768A5F1B; Thu, 2 May 2019 15:21:06 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0741B5B38 for ; Thu, 2 May 2019 15:21:04 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:21:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="147662891" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga007.fm.intel.com with SMTP; 02 May 2019 06:21:01 -0700 Received: by (sSMTP sendmail emulation); Thu, 02 May 2019 14:21:01 +0100 Date: Thu, 2 May 2019 14:21:01 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, bluca@debian.org Message-ID: <20190502132100.GB1980@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-5-bruce.richardson@intel.com> <3343772.7GDin1kDO3@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <3343772.7GDin1kDO3@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502132101.SVu5txw5fpVqlGZ8l-Lwu5Q7OoyrCW1wbGTiY2kojeM@z> On Thu, May 02, 2019 at 02:38:49PM +0200, Thomas Monjalon wrote: > Hi, > > I will probably have a ton of comments about adding a new compilation tests, > and I think it is a bit late for such an addition. > However, all the fixes should go in 19.05. > > 26/04/2019 18:50, Bruce Richardson: > > The pkg-config file generated as part of the build of DPDK should allow > > applications to be built with an installed DPDK. We can test this as > > part of the build by doing an install of DPDK to a temporary directory > > within the build folder, and by then compiling up a few sample apps > > using make working off that directory. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Luca Boccassi > > --- > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > +############## > > +# Test installation of the x86-default target, to be used for checking > > +# the sample apps build using the pkg-config file for cflags and libs > > +############### > > I would prefer simpler comment formatting. > It makes this test very special. Your comment implies that it is not :-) Sure, I can reduce the highlighting. > > > +build_path=build-x86-default > > +DESTDIR=`pwd`/$build_path/install-root ; export DESTDIR > > export DESTDIR=... is not supported everywhere? No 100% sure, so left it like this just in case. > I prefer new shell substitution syntax $() instead of backquotes. > Sure, I agree it's more readable. > > +$ninja_cmd -C $build_path install > > + > > +pc_file=$(find $DESTDIR -name libdpdk.pc) > > +PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH > > + > > +# rather than hacking our environment, just edit the .pc file prefix value > > +sed -i -e "s|prefix=|prefix=$DESTDIR|" $pc_file > > What is the alternative? > Cannot we configure meson with the right prefix? > See previous discussion. Short answer, yes we can, but the prefix does not apply to kernel modules as they always install in /lib/modules folder. > > +for example in helloworld l2fwd l3fwd skeleton timer; do > > + echo "## Building $example" > > + $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example > > +done > > + > > +echo "" > > +echo "## $0: Completed OK" > > This last log is uncommon. > Yes, it is. However, due to parallelism, sometimes there is an error message printed out that scrolls off-screen as the other build processes come to a halt. I felt it worthwhile to add this at the end to ensure it was clear whether things succeeded or not. If you prefer, I can change it to a print on failure? /Bruce