From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9753A0AC5 for ; Thu, 2 May 2019 15:46:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDDD45F2C; Thu, 2 May 2019 15:46:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 53B8C5F20; Thu, 2 May 2019 15:46:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="228659774" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by orsmga001.jf.intel.com with SMTP; 02 May 2019 06:46:33 -0700 Received: by (sSMTP sendmail emulation); Thu, 02 May 2019 14:46:33 +0100 Date: Thu, 2 May 2019 14:46:32 +0100 From: Bruce Richardson To: David Marchand Cc: Thomas Monjalon , dev , dpdk stable Message-ID: <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502134632.MMQvi68iWh-q0tGqRo8eos2KzVaL8OaVoak27jXh_Pg@z> On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > <[1][2]thomas@monjalon.net> > > wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes fixes warnings seen when compiling DPDK > on > > Fedora 30. > > > In most cases these warnings appear to be false positives, > which > > means we > > > have the option to just disable the warning. Because the > changes > > required > > > to the code to silence the warnings are fairly small I've > chosen > > in all cases > > > to change the code rather than disable the warnings, but > I'm open > > to doing > > > the opposite if it's felt it's a better solution. [One > thing I > > didn't like > > > about disabling the warnings is that the disabling flags > are not > > supported > > > by clang, so adding them involves compiler checks :-(] > > > > > > NOTE: this set does not cover all warnings with GCC9, but > it does > > cover > > > those seen when building with meson. There is still one > warning > > disable > > > flag needed when building with make, which will need a > follow-on > > set to > > > fix. > > > > > > Bruce Richardson (4): > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > bus/fslmc: fix printf of null pointer > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: [2][3]stable@dpdk.org > > Applied, thanks > > > > I had a comment on patch 2, and the bigger problem is > > -Waddress-of-packed-member. > > The quicker solution for now is to downgrade it to warning only > so that > > we can fix the parts later rather than globally disable it. > > -- > Well, it is already a warning, it's just that with make we build by > default > with -Werror when building from git. > > Err, why don't we have -Werror for meson ? > Because it's generally not a good idea to use -Werror by default. However, the test-meson-build script (which we should all be using for test compilation before upstreaming) sets it for all builds. /Bruce