From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7AE32A0AC5 for ; Thu, 2 May 2019 16:10:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D7E37D05; Thu, 2 May 2019 16:10:52 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by dpdk.org (Postfix) with ESMTP id 2895B7CEB for ; Thu, 2 May 2019 16:10:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xo0LD4bsD2O9Q+QB043S4SqUpPBtneU0J2togtDo1jE=; b=X+7YYLozE0GzpG4AKggo2PYnhRQuT7/QGjDqe0hU/B64s3UuBdgv6+ZKg8MmrZkQXz3i9EYrWYj0kwn6ipW3vE7dJNWeoBeYdKpvic+MBd28dgYVzz+SBgpGhYxVNfWLJPeKSdDq6prFG+jsQ2AqiugFd+Foey+B2OnBridXgNI= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3620.eurprd05.prod.outlook.com (52.133.46.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Thu, 2 May 2019 14:10:50 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1856.008; Thu, 2 May 2019 14:10:50 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Thread-Index: AQHU/nsrYNMPIHh34k2QyaEH4qj+DqZX5CqA Date: Thu, 2 May 2019 14:10:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a6850ab-a30c-438b-9f0d-08d6cf07fb03 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3620; x-ms-traffictypediagnostic: AM0PR0502MB3620: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39860400002)(396003)(136003)(376002)(199004)(189003)(68736007)(305945005)(102836004)(8936002)(8676002)(7736002)(81166006)(74316002)(81156014)(446003)(5660300002)(2906002)(11346002)(25786009)(6436002)(33656002)(86362001)(186003)(53936002)(229853002)(99286004)(14454004)(476003)(6246003)(110136005)(66066001)(7696005)(256004)(486006)(66476007)(76176011)(4326008)(26005)(478600001)(6636002)(71200400001)(66556008)(66946007)(3846002)(73956011)(4744005)(71190400001)(6506007)(9686003)(316002)(76116006)(64756008)(66446008)(6116002)(52536014)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3620; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HWv8aur1XQaxq3Z0phT/BTU+lbkOkm0Ri4+QjXl8NAu4F6myYA1tdSjNEg+Q1nILyUwLLXSyBzRV7v7TaUcCKegXoBWPb3AhsEUfSXzLqmaLOy5NzUrb6+M+TEbiuLV8pJjSQLNW7yTalrW+jRgPGMjQhfl32TKHidQ4uqH6HSrzwnDsu39mJQh5CrUdetE874MviJLlw0Rr6nTfYz4Jy5SaHMBP1jNoEfTjtbMFiSe9N86wf1MIi/itBYaahLU9qOcdlHcoBYgB5CWhyYn+SbKqzajwvD8koG0Njyo/mLDO8NE/hMu4kM11KmpSRpSL7Q0blnhswFTd/iaEWcthmiiVoOhMiGv+WDuSjM3JFpPV12cep0NRsAJiUep92BsqdOYKfefXX+o96ouT4OfBCsFyxHBMhBaeXqYBddoCAQk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a6850ab-a30c-438b-9f0d-08d6cf07fb03 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 14:10:50.0461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3620 Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502141050.UwUBqEd9GubcqF6dCmHz-5ruVXiztV9eDjkOKynHx4Q@z> Hi Dekel, Monday, April 29, 2019 2:01 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files >=20 > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. Good cleanup. I am basically OK w/ the series, you can add my Acked-by to next version. S= ee small comment below. >=20 > Dekel Peled (4): > net/mlx5: remove unused functions > net/mlx5: add missing validation of null pointer This one should be "fix ..." and not "add ..." + Cc for stable. Since you a= ctually fix a possible segfault.=20 > net/mlx5: fix description of function return value > net/mlx5: move locally used functions to static >=20 > drivers/net/mlx5/mlx5_rxq.c | 218 +++++++++++++++++++------------------= - > ----- > drivers/net/mlx5/mlx5_rxtx.h | 20 ---- drivers/net/mlx5/mlx5_txq.c | = 13 -- > - > 3 files changed, 94 insertions(+), 157 deletions(-) >=20 > -- > 1.8.3.1