From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86281A0AC5 for ; Thu, 2 May 2019 17:11:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B26D1B0FB; Thu, 2 May 2019 17:11:34 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 28B171B0F9 for ; Thu, 2 May 2019 17:11:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BDA9A24AB9; Thu, 2 May 2019 11:11:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 May 2019 11:11:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tzDmsA38p87rnugBcZW6BdVo7w+okFdG1GLC9yJ628Q=; b=aA/8d8YY3ihu HQWqAIVIULldz3OZxqNqow1jhvXQ3emPSeQ+aiXapfk/dm3Kcu+k+Pl+FuEX328x btsQVWpUYAiwF9Y2oXh9HymPx66HboEV+pj8+gDYEGDJQuoLHcFEWvO7L++oHPlD FdRxPjc4kqp1FfeamVpD+vCRY+cU/Bg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tzDmsA38p87rnugBcZW6BdVo7w+okFdG1GLC9yJ62 8Q=; b=gPCNvMpuvPNKmK42S9kon2U2ybN7C44RS8Q0pTH4puVJcekEFM33RGZso RVYnUGSQwZ0hhEIA8hT9BLA/InrLvpGJ4PDMliKFKvBnkulfCLjV4RGu4BLrkGrI xl5CJ0vEBIxzzF9jjgTDzecY6Qvtke9vfMNS60uKTKRp8a2iBgXGHC4ZVXxE+oEA 3t75w+wVDzJI67N75eVKDJ+hd6hS7VfSSIq9NR7vExsuNjBceHJv8zavjPMeIZJq kyi60ezejEA1KTsuc5e3ows/AuGBu+RnF0Xpcvf0fEdfoaU/8EWk8xo0BD0ccbcq sbQti9drRtN+KSljqNzdVALwFAgtg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 90666103D2; Thu, 2 May 2019 11:11:31 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: Bruce Richardson , dev@dpdk.org Date: Thu, 02 May 2019 17:11:30 +0200 Message-ID: <5943797.eKmBmZ8x9O@xps> In-Reply-To: <33cd0a15409b4af2d93bcfba804566ea09e7c0cb.camel@debian.org> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190502131738.GA1980@bricha3-MOBL.ger.corp.intel.com> <33cd0a15409b4af2d93bcfba804566ea09e7c0cb.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502151130.U1QhC1PD7BBJN0XcZ-c7xY32ZSrGEsHqJxX_RsuAcJk@z> 02/05/2019 16:08, Luca Boccassi: > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > > > 26/04/2019 16:56, Bruce Richardson: > > > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi > > > > > > wrote: > > > > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi > > > > > > > > wrote: > > > > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson > > > > > > > > > wrote: > > > > > > > > > > +# > > > > > > > > > > rather > > > > > > > > > > than hacking our environment, just edit the .pc file > > > > > > > > > > prefix > > > > > > > > > > value > > > > > > > > > > +sed > > > > > > > > > > -i "s|prefix=|prefix=$DESTDIR|" > > > > > > > > > > $PKG_CONFIG_PATH/libdpdk.pc > > > > > > > > > > > > > > > > > > What about just using meson's prefix option instead? > > > > > > > > > Which is > > > > > > > > > how > > > > > > > > > it > > > > > > > > > would be used in a real use case > > > > > > > > > > > > > > > > I don't think that would fully work, as my understanding > > > > > > > > is that > > > > > > > > the > > > > > > > > prefix > > > > > > > > option would apply only to the /usr/local parts, but not > > > > > > > > to the > > > > > > > > kernel > > > > > > > > modules which would still try and install in /lib/. > > > > > > > > > > > > > > What about doing a meson configure -Denable_kmods=false > > > > > > > before the > > > > > > > ninja install? The modules are not needed for that test > > > > > > > anyway, > > > > > > > right? > > > > > > > Alternatively, the kernel src dir could be symlinked in the > > > > > > > build > > > > > > > path, > > > > > > > and the kernel_dir option could be used > > > > > > > > > > > > > > I'm just worried that the test should be as "realistic" as > > > > > > > possible, to > > > > > > > avoid missing something > > > > > > > > > > > > Yes, I did think of that too, but it does mean doing another > > > > > > configuration > > > > > > run in meson, and possibly a rebuild too if the > > > > > > rte_build_config.h > > > > > > file > > > > > > changes. Therefore I decided to use DESTDIR for the sake of > > > > > > speed > > > > > > here. I > > > > > > assumed there would be a pkg-config variable to adjust the > > > > > > output > > > > > > paths > > > > > > based on a sysroot, but couldn't find a suitable one. > > > > > > [...] > > > > > There actually is a pkg-config binary option, I just tried and > > > > > it works > > > > > (it seems to be disabled by default on Debian and derivatives): > > > > > -- > > > > > define-prefix > > > > > > > > > > > > > Any cmdline options to pkg-config don't solve the problem here as > > > > it means > > > > that the makefiles for any app need to be modified to use all > > > > those. > > > > > > It looks to be a good solution. > > > Being able to update the DPDK install directory when building > > > an application should be a mandatory requirement. > > > I suggest to wrap the call to pkg-config so we can have this > > > ability. > > > > > > > I would have expected that this issue has already been solved for > > packagers. I was surprised that I couldn't find an easy way to do so. > > Packagers use standard paths - so it never becomes a problem. > > If editing the file on the fly is not acceptable for the test script, > then I'd suggest to fall back to the pkg-config option, and just > document the need to use it in the docs for this scenarios. What I mean is that we should be able to compile our apps after using DESTDIR, not related to the test script. Can we use an environment variable like RTE_TARGET? DPDK_DIR?