From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 61D33A0AC5 for ; Thu, 2 May 2019 20:13:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DBD41B1D6; Thu, 2 May 2019 20:13:38 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40]) by dpdk.org (Postfix) with ESMTP id 5E7C11B1A0; Thu, 2 May 2019 20:13:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kroqRpIoq0lk2Ro6VDPtK2oe0fbetvomoYgM32hRmOU=; b=i22PnRp70ZZiXyDNQJndFgQmb+mtiUecUDxL2mfsaN6y1IhhoJEWaDJdt3b2qmplPEPOCwvyUDFNCA1uhK9gardO0Bgfs6dancztYDYEZ8YDBgndU1RpHP5oUirRdvSwn798ZrQA3AVao0+NmOzBC3MHKXW3BqAdMKtGFH+jMT8= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3979.eurprd05.prod.outlook.com (52.134.67.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Thu, 2 May 2019 18:13:35 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Thu, 2 May 2019 18:13:35 +0000 From: Yongseok Koh To: Dekel Peled CC: Shahaf Shuler , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2 3/4] net/mlx5: fix description of function return value Thread-Index: AQHVAPh1WNROOrG+5UiSYBGkFOXYK6ZYI5EA Date: Thu, 2 May 2019 18:13:35 +0000 Message-ID: <08F3CC29-B432-47BB-B887-1D53908CA4C4@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2f05453-85b8-476c-16ce-08d6cf29e472 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3979; x-ms-traffictypediagnostic: DB3PR0502MB3979: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(366004)(136003)(199004)(189003)(6436002)(6116002)(3846002)(68736007)(14454004)(73956011)(37006003)(91956017)(316002)(54906003)(6862004)(8936002)(6636002)(83716004)(450100002)(4326008)(186003)(71200400001)(71190400001)(66946007)(99286004)(2906002)(66066001)(66476007)(66556008)(66446008)(64756008)(229853002)(26005)(6486002)(5660300002)(76116006)(486006)(305945005)(7736002)(6506007)(82746002)(6246003)(8676002)(53936002)(81166006)(81156014)(25786009)(33656002)(102836004)(256004)(6512007)(86362001)(446003)(11346002)(476003)(76176011)(478600001)(36756003)(2616005)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3979; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gENtuQ7HGCW119J4/D0A+MgQFxtQg+q+q3COhBzl9mTosdGQLWnBL6HqMCOZb1fijdn14+SK4fNrbFx1h/jQAykB3HXqgvwWGiJnqUlkLt7x1ZDrIk10ZG0+oCT5RmqiUDLFtP6vTWpCdbGXutRAsU+zFodlk9UtPCU2BfmuuvtRm5xTSRZsl8TXh0j3vKE/BBtWRAfs3ngvw2jbDMKs2oWluo5HJRqVTGCJl8TN9wPe7OlahUKFywPdeCZ3RnAdCBhvOIL1hcZEu/tBFfopqAOxcwP1dr7MDqMrRUj8dn0UTd7awXMv9ARxkPPUTeBLjzcDP4VpNCXdV5yCHHt4SAOJElEiy34f7rm9gJ+ITORI3x0KXlr9upKLEX1SiBq5ZAI9U8lsVJvLyPng9qjSSUr5LKk6zkDJPAmK7OA2U1g= Content-Type: text/plain; charset="UTF-8" Content-ID: <170B68DF04395747B16579A844C0D484@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2f05453-85b8-476c-16ce-08d6cf29e472 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 18:13:35.1193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3979 Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502181335.7IOBB_ais3VeCQO4KrDPGb019vw47iPvFDIgSwfdldQ@z> > On May 2, 2019, at 8:01 AM, Dekel Peled wrote: >=20 > Return value of function mlx5_rxq_releasable() was not described > correctly in function description. >=20 > This patch updates the description to correctly describe the optional > return values. >=20 > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index c9c2a14..a547f2a 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1546,8 +1546,9 @@ struct mlx5_rxq_ctrl * > * RX queue index. > * > * @return > - * 1 if the queue can be released, negative errno otherwise and rte_er= rno is > - * set. > + * 1 if the queue can be released > + * 0 if the queue can not be released, there are references to it. > + * Negative errno and rte_errno is set if queue doesn't exist. > */ > int > mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx) > --=20 > 1.8.3.1 >=20