DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "yskoh@mellanox.com" <yskoh@mellanox.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField
Date: Fri, 3 May 2019 04:01:59 +0000	[thread overview]
Message-ID: <VE1PR08MB51499E6A833F16097D1FF4F898350@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
Message-ID: <20190503040159.hZ4bEfocq80EwTPWulkggcM1wJQtDpoJnUeMj9Iw7MM@z> (raw)
In-Reply-To: <21250682-EB2E-4F14-B75F-F09E1807C112@mellanox.com>

> > On May 1, 2019, at 9:12 PM, Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com> wrote:
> >
> >>
> >> Mellanox BlueField has a variant which doesn't have armv8 crypto
> extension.
> >> If crypto enabled binary runs on such a pltform, rte_eal_init()
> >> fails. To have binary compatibility across multiple variants, it is
> >> disabled by default and can be enabled for crypto enabled parts.
> >>
> >> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> >> ---
> >> config/defconfig_arm64-bluefield-linuxapp-gcc | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/config/defconfig_arm64-bluefield-linuxapp-gcc
> >> b/config/defconfig_arm64-bluefield-linuxapp-gcc
> >> index b496538819..6da9c2026d 100644
> >> --- a/config/defconfig_arm64-bluefield-linuxapp-gcc
> >> +++ b/config/defconfig_arm64-bluefield-linuxapp-gcc
> >> @@ -10,6 +10,12 @@ CONFIG_RTE_ARCH_ARM_TUNE="cortex-a72"
> >> CONFIG_RTE_MAX_NUMA_NODES=1
> >> CONFIG_RTE_CACHE_LINE_SIZE=64
> >>
> >> +# Crypto extension of armv8
> >> +#
> >> +# Disabled by default for binary compatibility.
> >> +# Can be enabled for crypto-enabled parts.
> >> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=n
> > How do you plan to support the Bluefield devices with crypto enabled? Do
> you plan to add another config?
> 
> Nope, user will have to enable it by modifying this file or specifying it in make
> command line.
Ok, I suggest documenting it somewhere.

> This is just to provide the default which can make majority of cases work well.
> For example, by default, mlx4/5 are even disabled in default x86 build config
> because not all users have drv/lib installed on their system. Users have to
> enable it if they want.
> 
> >> +
> >> # UMA architecture
> >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> >> CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> >> --
> >> 2.11.0


  parent reply	other threads:[~2019-05-03  4:02 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02  1:58 [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension Yongseok Koh
2019-05-02  1:58 ` Yongseok Koh
2019-05-02  1:58 ` [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField Yongseok Koh
2019-05-02  1:58   ` Yongseok Koh
2019-05-02  4:12   ` Honnappa Nagarahalli
2019-05-02  4:12     ` Honnappa Nagarahalli
2019-05-02  5:40     ` Yongseok Koh
2019-05-02  5:40       ` Yongseok Koh
2019-05-03  4:01       ` Honnappa Nagarahalli [this message]
2019-05-03  4:01         ` Honnappa Nagarahalli
2019-05-02  4:13 ` [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension Honnappa Nagarahalli
2019-05-02  4:13   ` Honnappa Nagarahalli
2019-05-02  5:46   ` Yongseok Koh
2019-05-02  5:46     ` Yongseok Koh
2019-05-02 10:00     ` Jerin Jacob Kollanukkaran
2019-05-02 10:00       ` Jerin Jacob Kollanukkaran
2019-05-03  3:57     ` Honnappa Nagarahalli
2019-05-03  3:57       ` Honnappa Nagarahalli
2019-05-03  9:57       ` Yongseok Koh
2019-05-03  9:57         ` Yongseok Koh
2019-05-03 12:28 ` [dpdk-dev] [PATCH v2] build: disable " Yongseok Koh
2019-05-03 12:28   ` Yongseok Koh
2019-05-03 15:02   ` Honnappa Nagarahalli
2019-05-03 15:02     ` Honnappa Nagarahalli
2019-05-03 16:10     ` Honnappa Nagarahalli
2019-05-03 16:10       ` Honnappa Nagarahalli
2019-05-03 17:50       ` Yongseok Koh
2019-05-03 17:50         ` Yongseok Koh
2019-05-06 21:46         ` [dpdk-dev] [dpdk-stable] " Yongseok Koh
2019-05-06 21:46           ` Yongseok Koh
2019-05-07  7:59           ` Jerin Jacob Kollanukkaran
2019-05-07  7:59             ` Jerin Jacob Kollanukkaran
2019-05-07 11:03             ` Honnappa Nagarahalli
2019-05-07 11:03               ` Honnappa Nagarahalli
2019-05-07 12:02               ` Jerin Jacob Kollanukkaran
2019-05-07 12:02                 ` Jerin Jacob Kollanukkaran
2019-05-03 22:13   ` [dpdk-dev] " Dharmik Thakkar
2019-05-03 22:13     ` Dharmik Thakkar
2019-05-06 21:41     ` Yongseok Koh
2019-05-06 21:41       ` Yongseok Koh
2019-05-07 21:11 ` [dpdk-dev] [PATCH v3] " Yongseok Koh
2019-05-07 21:11   ` Yongseok Koh
2019-05-13 19:26   ` Honnappa Nagarahalli
2019-05-13 19:26     ` Honnappa Nagarahalli
2019-06-03 23:11     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR08MB51499E6A833F16097D1FF4F898350@VE1PR08MB5149.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Gavin.Hu@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=pbhagavatula@marvell.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).