From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6A1C8A0AC5 for <public@inbox.dpdk.org>; Fri, 3 May 2019 12:54:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01EEE325F; Fri, 3 May 2019 12:54:56 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 59A5A3256 for <dev@dpdk.org>; Fri, 3 May 2019 12:54:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C759821ED6; Fri, 3 May 2019 06:54:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 May 2019 06:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=T8acQqYCFiGeY7s+Z3hZXH24gwoiLR8ChJM4UDmmFWA=; b=UTKb/R5QmWf0 vQrZsQ2WmtW4GhpH0BVgffxGMPY+ceQsybjD/A+sWO+Mn0CoNTcCrdhb0WHHV60z 7TT9XDp/WiZRwUNB9yehpFQrhCGy88GbNgg3IR3xDw/zRx12xxkZGnOXig/t+Tdo JSPsgluoR7igMvkb2tgMybU0p07H510= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=T8acQqYCFiGeY7s+Z3hZXH24gwoiLR8ChJM4UDmmF WA=; b=jCoc31g6MB3/qvMxmHhBE0Zb2JAi8XcjXnaj9V5HRTvwxqcJLZNCL/is/ 5fYsXXLYgGOdpQB35ElF36LeaF7NuSllkc+o4nXJxYrmAhkTSuhZOoKxziwGYcRE HCPDoBTwp+IeVi8BAY3d5pxeQhlnGPevG/HOXJp22BHL6EjT4aqtRxo7Rhuf8KOS 24K8iLjyWgz2MEuhjpJXtud6FZhtDq6WX4ZAb+M0SdXI9Lm/KRooBet58S+FzsES jfZ8GBRvG/6Biwkiy9gMZvFlMZS3LnI0+diz+XbeMRKciUTHpUPVNA+FBs4ybaDp lLqWFnGh2RSzWnix7MluDqt88S6ZQ== X-ME-Sender: <xms:_R3MXADmcia-TjiYZ-A6Pot83HsXkmhYSFppDbEgHmJaQ3UCNBUSqg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:_R3MXGrBUzEMcRCuHCoGxIQMXE9OtfWKlSbsIpWjkJrVXM-c10nkCw> <xmx:_R3MXPJVV734a1HUjIipj8QahyS8A4gKOwWGtKs825n8j87QuQckag> <xmx:_R3MXJCHha6XDqSwu_uVSQIdxELFhKEv-YLAPOLB_PmB8ac-jZ5J6w> <xmx:_R3MXGbUeFUb8Z-dVEA1sVMigo_ly2IdEJwEDqG97UkgM25gy7sbWQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 77471103D2; Fri, 3 May 2019 06:54:52 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Herakliusz Lipiec <herakliusz.lipiec@intel.com> Cc: dev@dpdk.org Date: Fri, 03 May 2019 12:54:50 +0200 Message-ID: <3343943.m8ruRHZ69c@xps> In-Reply-To: <20190503102857.15812-1-herakliusz.lipiec@intel.com> References: <20190425124817.28409-1-herakliusz.lipiec@intel.com> <20190503102857.15812-1-herakliusz.lipiec@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190503105450.Grre4nKvVSbfeLMe7_5COIWmJ08vzbrB6rgy8QdzHNM@z> 03/05/2019 12:28, Herakliusz Lipiec: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL and calling free everytime rte_mp_request_sync > is used. > > v5: > - change prefixes in commit titles. I already applied v4 with fixed titles, thanks