From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A4903A0AC5 for <public@inbox.dpdk.org>; Fri, 3 May 2019 14:28:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F6A04C95; Fri, 3 May 2019 14:28:23 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 4A2CD493D for <dev@dpdk.org>; Fri, 3 May 2019 14:28:21 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 3 May 2019 15:28:20 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x43CSHdE015990; Fri, 3 May 2019 15:28:17 +0300 From: Yongseok Koh <yskoh@mellanox.com> To: jerinj@marvell.com, thomas@monjalon.net Cc: dev@dpdk.org, bruce.richardson@intel.com, pbhagavatula@marvell.com, shahafs@mellanox.com, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, stable@dpdk.org Date: Fri, 3 May 2019 05:28:13 -0700 Message-Id: <20190503122813.8938-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190502015806.41497-1-yskoh@mellanox.com> References: <20190502015806.41497-1-yskoh@mellanox.com> Subject: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190503122813.G_Qc9WEWyZPbb4npojDtyr_WogAihW8plqinKr9bhFs@z> Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. It is known that not all the armv8 platforms have the crypto extension. For example, Mellanox BlueField has a variant which doesn't have it. If crypto enabled binary runs on such a platform, rte_eal_init() fails. '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will generate the crypto instructions only when crypto intrinsics are used. For the devices supporting 8.2 crypto or newer, compiler could generate such instructions beyond intrinsics or asm code. For example, compiler can generate 3-way exclusive OR instructions if sha3 is supported. However, it has to be enabled by adding '+sha3' as of today. In DPDK, armv8 cryptodev is the only one which requires the crypto support. As it even uses external library of Marvell which is compiled out of DPDK with crypto support and there's run-time check for required cpuflags, crypto support can be disabled in DPDK. Cc: stable@dpdk.org Signed-off-by: Yongseok Koh <yskoh@mellanox.com> --- v2: * disable crypto support instead of having a build config config/arm/meson.build | 2 +- mk/machine/armv8a/rte.vars.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 7fa6ed3105..abc8cf346c 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -74,7 +74,7 @@ flags_octeontx2_extra = [ ['RTE_USE_C11_MEM_MODEL', true]] machine_args_generic = [ - ['default', ['-march=armv8-a+crc+crypto']], + ['default', ['-march=armv8-a+crc']], ['native', ['-march=native']], ['0xd03', ['-mcpu=cortex-a53']], ['0xd04', ['-mcpu=cortex-a35']], diff --git a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk index 8252efbb7b..5e3ffc3adf 100644 --- a/mk/machine/armv8a/rte.vars.mk +++ b/mk/machine/armv8a/rte.vars.mk @@ -28,4 +28,4 @@ # CPU_LDFLAGS = # CPU_ASFLAGS = -MACHINE_CFLAGS += -march=armv8-a+crc+crypto +MACHINE_CFLAGS += -march=armv8-a+crc -- 2.11.0