From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, nhorman@tuxdriver.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API
Date: Fri, 3 May 2019 16:34:20 +0200 [thread overview]
Message-ID: <1556894060-13573-4-git-send-email-david.marchand@redhat.com> (raw)
Message-ID: <20190503143420.Xmdg9WnWqIAoXAcuMM7lB6sYglXUbj2owGhas5TFOWU@z> (raw)
In-Reply-To: <1556894060-13573-1-git-send-email-david.marchand@redhat.com>
The incriminated commit broke the detection of new symbols skipping the
EXPERIMENTAL step before entering a stable abi section.
sed won't return an error, check a null output instead.
Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-symbol-change.sh | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 9ada81e..116c311 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -111,15 +111,24 @@ check_for_rule_violations()
# A symbol can not enter a non experimental
# section directly
- if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ]
+ if [ -z "$oldsecname" ]
then
- echo -n "ERROR: symbol $symname "
- echo -n "is added in the $secname "
- echo -n "section, but is expected to "
- echo -n "be added in the EXPERIMENTAL "
- echo "section of the version map"
- ret=1
- continue
+ if [ "$secname" = 'EXPERIMENTAL' ]
+ then
+ echo -n "INFO: symbol $symname has "
+ echo -n "been added to the "
+ echo -n "EXPERIMENTAL section of the "
+ echo "version map"
+ continue
+ else
+ echo -n "ERROR: symbol $symname "
+ echo -n "is added in the $secname "
+ echo -n "section, but is expected to "
+ echo -n "be added in the EXPERIMENTAL "
+ echo "section of the version map"
+ ret=1
+ continue
+ fi
fi
# This symbol is moving inside a section, nothing to do
--
1.8.3.1
next prev parent reply other threads:[~2019-05-03 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 15:03 ` Neil Horman
2019-05-03 15:03 ` Neil Horman
2019-05-03 17:16 ` David Marchand
2019-05-03 17:16 ` David Marchand
2019-05-06 12:56 ` David Marchand
2019-05-06 12:56 ` David Marchand
2019-05-06 15:43 ` Neil Horman
2019-05-06 15:43 ` Neil Horman
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` David Marchand [this message]
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
2019-05-09 21:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 21:40 ` Thomas Monjalon
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
2019-05-03 16:15 ` Ray Kinsella
2019-05-03 17:12 ` David Marchand
2019-05-03 17:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556894060-13573-4-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).