Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression

[Neil Horman <nhorman@tuxdriver.com>]

On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> Even if rare, the check script should handle removing a section.
> 
> Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/check-symbol-change.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 8da7650..d5fad04 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -32,6 +32,7 @@ build_map_changes()
>  		# symbol rule below
>  		/^.*{/ {
>  			gsub("+", "");
> +			gsub("-", "");
>  			if (in_map == 1) {
>  				sec=$(NF-1); in_sec=1;
>  			}
> -- 
> 1.8.3.1
> 
> 
Don't you also need to add some logic in the symbol detection match rule to
print an appropriate indicator that a symbol is being removed?  With just this
change, you will note that you are parsing a section, but you will never trigger
a symbol match

Neil