From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 36A2CA0AC5 for ; Fri, 3 May 2019 18:06:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3AB35F62; Fri, 3 May 2019 18:06:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id DCB635B40; Fri, 3 May 2019 18:06:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x43G4lOX031503; Fri, 3 May 2019 09:06:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Zc5GF+XAWYdwR730/I6UNCY7MsLrckGJEuly7UrC2Xc=; b=c4QseDc9UxwVoHd4MlW554sQRUCLByCb3i1mzbt0FSpWVsYUkX5beQf9aRi7iAcr049K bOjHn8RdAe/n8nGYUvxn5GN5aSqjvBFOaDGngdLvE38BOSeq81fDkkzW0R8VbiWjetua BMVZ4SpFZr0A9oftsmuKIz5RLWd8rTYbUW8JYZVh+8K0SdVFIuyuq2FLOEerteVpL0d7 dAt6OO7zMpQfKtS5puXvcf8FRGyT+wBa+zr7PNa+P96YNEm7EN+VC0wGreBuIlY6y0E3 IDnkhKtf4/aAWob1IZdOUIBGBFS3igzTjMt9B6pg+X1+kvXWgY3JYkOSdWjRB/F3ad3g pw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2s8gtb1spx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 03 May 2019 09:06:52 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 3 May 2019 09:06:52 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.53) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 3 May 2019 09:06:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zc5GF+XAWYdwR730/I6UNCY7MsLrckGJEuly7UrC2Xc=; b=l7ijkb73ovGj4jAPfdR/GcBHUGEPhAyp88GT0a6MBOM8rM6HZsOVHC6nkNpJ8eHXT5yb6ba+90TOBtOy5n7es03axoIziIOEjRlMBiwxIWjoS9yMiltDaFfHP4xSD89OOl9j0KXgvilWx8CRj6uhGM/+r0knErWaZ1SckSmMXcc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2807.namprd18.prod.outlook.com (20.179.57.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Fri, 3 May 2019 16:06:47 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d%3]) with mapi id 15.20.1856.008; Fri, 3 May 2019 16:06:47 +0000 From: Jerin Jacob Kollanukkaran To: Yongseok Koh , "thomas@monjalon.net" CC: "dev@dpdk.org" , "bruce.richardson@intel.com" , Pavan Nikhilesh Bhagavatula , "shahafs@mellanox.com" , "gavin.hu@arm.com" , "Honnappa.Nagarahalli@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH v2] build: disable armv8 crypto extension Thread-Index: AdUByhgqIzV1P9OfStioscPksE7imA== Date: Fri, 3 May 2019 16:06:47 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.61.47.48] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d15a36e7-af2c-4618-7c2f-08d6cfe15840 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2807; x-ms-traffictypediagnostic: BYAPR18MB2807: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(366004)(396003)(376002)(39860400002)(13464003)(199004)(189003)(316002)(6246003)(86362001)(6436002)(26005)(66446008)(53936002)(256004)(110136005)(3846002)(305945005)(14454004)(64756008)(66476007)(66946007)(81156014)(76116006)(74316002)(73956011)(14444005)(66556008)(99286004)(6116002)(4326008)(2501003)(54906003)(9686003)(55016002)(478600001)(81166006)(25786009)(8676002)(7736002)(8936002)(71190400001)(71200400001)(66066001)(229853002)(7696005)(102836004)(52536014)(5660300002)(53546011)(6506007)(186003)(68736007)(2906002)(476003)(33656002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2807; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zyVlYvfaQ/Ier1OpxmmA5JAP8903GkuBJvATLgBeFkA437t/GT0exBCNgZ3ynAnBhvcNd8ZgY8neEhhUmCmhNO8n0NgNuUko86Yn721E1cEmR6ik5ninDQQDmZbFFvcm9Puz/hA/PvEFRMpVewdbqO5wzg7Pe1XWyeVTL16q9HSVyp43dvtGJJmntXOufHN/x/FR3fxuULPskx9ml9SnzT0aGBTtQA5ridflid23HzwCfjXFNuyvE6sbTLVI5vNSI2+TQclhT+K729ZRQ6kNifqvcJpV5Gb+5PGeJtO1nK6YxPYe4/vFhnUEdGgC6AjqPmgnovSvptRmIN980PaXX1sgPuLHvHOiNgaumrNW9CM7xI3P0Ztw/DgtzY6iy7WhMyCkFcccCkWcNqc6f6eSOzEhHXgaNmTeLLUk+kupnss= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d15a36e7-af2c-4618-7c2f-08d6cfe15840 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 16:06:47.3375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2807 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-03_09:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503160647.81HgGoFq89rFrXQTnkzA4hR0LQ7ae54cd54KyADQIK4@z> > -----Original Message----- > From: Yongseok Koh > Sent: Friday, May 3, 2019 5:58 PM > To: Jerin Jacob Kollanukkaran ; thomas@monjalon.net > Cc: dev@dpdk.org; bruce.richardson@intel.com; Pavan Nikhilesh Bhagavatula > ; shahafs@mellanox.com; gavin.hu@arm.com; > Honnappa.Nagarahalli@arm.com; stable@dpdk.org > Subject: [EXT] [PATCH v2] build: disable armv8 crypto extension > > Per armv8 crypto extension support, make build always enable it by defa= ult as > long as compiler supports the feature while meson build only enables it f= or > 'default' machine of generic armv8 architecture. >=20 > It is known that not all the armv8 platforms have the crypto extension. F= or > example, Mellanox BlueField has a variant which doesn't have it. If crypt= o > enabled binary runs on such a platform, rte_eal_init() fails. >=20 > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it = will > generate the crypto instructions only when crypto intrinsics are used. > For the devices supporting 8.2 crypto or newer, compiler could generate s= uch > instructions beyond intrinsics or asm code. For example, compiler can gen= erate > 3-way exclusive OR instructions if sha3 is supported. However, it has to = be > enabled by adding '+sha3' as of today. >=20 > In DPDK, armv8 cryptodev is the only one which requires the crypto suppor= t. > As it even uses external library of Marvell which is compiled out of DPDK= with > crypto support and there's run-time check for required cpuflags, crypto s= upport > can be disabled in DPDK. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > --- Acked-by: Jerin Jacob