From: Ray Kinsella <mdr@ashroe.eu>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols
Date: Fri, 3 May 2019 17:15:44 +0100 [thread overview]
Message-ID: <d72fad86-be68-9125-5640-531f39f3281e@ashroe.eu> (raw)
Message-ID: <20190503161544.SG5SWI91gszaG4EpbXgwqTZjP6PztY0FL9wVRrDcvg4@z> (raw)
In-Reply-To: <1556894060-13573-1-git-send-email-david.marchand@redhat.com>
Hi David,
Do you have this script wired into the DPDK CI?
Or is this purely for testing before packaging?
Ray K
On 03/05/2019 15:34, David Marchand wrote:
> No need to shout when we are just reordering symbols in a section.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/check-symbol-change.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 40eb953..8da7650 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -121,6 +121,12 @@ check_for_rule_violations()
> continue
> fi
>
> + # This symbol is moving inside a section, nothing to do
> + if [ "$oldsecname" = "$secname" ]
> + then
> + continue
> + fi
> +
> # This symbol is moving between two sections (the
> # original section is not experimental).
> # This can be legit, just warn.
>
next prev parent reply other threads:[~2019-05-03 16:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 14:34 David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 15:03 ` Neil Horman
2019-05-03 15:03 ` Neil Horman
2019-05-03 17:16 ` David Marchand
2019-05-03 17:16 ` David Marchand
2019-05-06 12:56 ` David Marchand
2019-05-06 12:56 ` David Marchand
2019-05-06 15:43 ` Neil Horman
2019-05-06 15:43 ` Neil Horman
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-09 21:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 21:40 ` Thomas Monjalon
2019-05-03 16:15 ` Ray Kinsella [this message]
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
2019-05-03 17:12 ` David Marchand
2019-05-03 17:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d72fad86-be68-9125-5640-531f39f3281e@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).