From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 02DB77CDA for <dev@dpdk.org>; Fri, 3 May 2019 18:25:09 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 09:25:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,426,1549958400"; d="scan'208";a="147925336" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.248]) by orsmga003.jf.intel.com with SMTP; 03 May 2019 09:25:04 -0700 Received: by (sSMTP sendmail emulation); Fri, 03 May 2019 17:25:03 +0100 Date: Fri, 3 May 2019 17:25:03 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Reshma Pattan <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, "viktorin@rehivetech.com" <viktorin@rehivetech.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> Message-ID: <20190503162502.GA338@bricha3-MOBL.ger.corp.intel.com> References: <20190502093334.7546-1-reshma.pattan@intel.com> <CAJFAV8xHeGHBtw7eJbMwogb7J4Z7Yw9x33Od1Nw=QFBU5M8eYg@mail.gmail.com> <1787462.1VlDKmKezL@xps> <BYAPR18MB2424ACF0426C8B5310C6BDA0C8350@BYAPR18MB2424.namprd18.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <BYAPR18MB2424ACF0426C8B5310C6BDA0C8350@BYAPR18MB2424.namprd18.prod.outlook.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 03 May 2019 16:25:10 -0000 On Fri, May 03, 2019 at 04:01:38PM +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon > > Sent: Thursday, May 2, 2019 9:27 PM > > To: Reshma Pattan <reshma.pattan@intel.com> > > Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com> > > Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 > > > > 02/05/2019 17:00, David Marchand: > > > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan > > > <reshma.pattan@intel.com> > > > wrote: > > > > > > > gcc 9 on Fedora 30 gives an error > > > > "taking address of packed member may result in an unaligned pointer > > > > value" warnings. > > > > > > > > For clang builds this warning is already disabled, so disable > > > > "-Waddress-of-packed-member" for gcc builds also. > > > > > > > > Snippet of build error: > > > > ...lib/librte_eal/linux/eal/eal_memalloc.c: In function ‘alloc_seg_walk’: > > > > ...lib/librte_eal/linux/eal/eal_memalloc.c:768:12: error: taking > > > > address of packed member of ‘struct rte_mem_config’ may result in an > > > > unaligned pointer value [-Werror=address-of-packed-member] > > > > 768 | cur_msl = &mcfg->memsegs[msl_idx]; > > > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > > > > > > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com> > > > > > > > > > > > Tested on rhel-7 and fedora-30. > > > Tested-by: David Marchand <david.marchand@redhat.com> > > > > Applied, thanks > > Its been found that one of the armv7 toolchain treats > -Wno-address-of-packed-member as unrecognized command line option, > Hence armv7 build fails on dpdk.org master now. Not sure it is specific to armv7 or compiler? > > Armv7 is not maintained and I don’t think, it has any use case for DPDK. > If everyone agrees IMO it is better remove the arm 32bit support. > > arm-buildroot-linux-gnueabihf-gcc -v > Using built-in specs. > COLLECT_GCC=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > bin/arm-buildroot-linux-gnueabihf-gcc.br_real > COLLECT_LTO_WRAPPER=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > libexec/gcc/arm-buildroot-linux-gnueabihf/7.3.0/lto-wrapper > Target: arm-buildroot-linux-gnueabihf > Configured with: ./configure > --prefix=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --sysconfdir=/opt/armv7-eabihf--glibc--stable-2018.11-1/etc > --enable-static --target=arm-buildroot-linux-gnueabihf > --with-sysroot=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > arm-buildroot-linux-gnueabihf/sysroot > --disable-__cxa_atexit --with-gnu-ld --disable-libssp --disable-multilib > --with-gmp=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-mpc=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-mpfr=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-pkgversion='Buildroot 2018.08.1-00003-g576b333' > --with-bugurl=http://bugs.buildroot.net/ --disable-libquadmath > --enable-tls --disable-libmudflap --enable-threads --without-isl > --without-cloog --disable-decimal-float --with-abi=aa > pcs-linux --with-cpu=cortex-a9 --with-fpu=vfpv3-d16 --with-float=hard > --with-mode=arm --enable-languages=c,c++ > --with-build-time-tools=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > arm-buildroot-linux-gnueabihf/bin --enable-shared --disable-libgomp > Thread model: posix > gcc version 7.3.0 (Buildroot 2018.08.1-00003-g576b333) > > error log: > > dpdk.org/lib/librte_eal/linux/eal/eal_vfio_mp_sync.c: At top level: > cc1: error: unrecognized command line option > ‘-Wno-address-of-packed-member’ [-Werror] > cc1: all warnings being treated as errors > Are you sure there is not another error as well? GCC silently ignores flags like this one normally, but does report them as unrecognised if-and-only-if another error or warning is given too. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 11EFFA0AC5 for <public@inbox.dpdk.org>; Fri, 3 May 2019 18:25:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EEA27CE2; Fri, 3 May 2019 18:25:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 02DB77CDA for <dev@dpdk.org>; Fri, 3 May 2019 18:25:09 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 09:25:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,426,1549958400"; d="scan'208";a="147925336" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.248]) by orsmga003.jf.intel.com with SMTP; 03 May 2019 09:25:04 -0700 Received: by (sSMTP sendmail emulation); Fri, 03 May 2019 17:25:03 +0100 Date: Fri, 3 May 2019 17:25:03 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Reshma Pattan <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, "viktorin@rehivetech.com" <viktorin@rehivetech.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> Message-ID: <20190503162502.GA338@bricha3-MOBL.ger.corp.intel.com> References: <20190502093334.7546-1-reshma.pattan@intel.com> <CAJFAV8xHeGHBtw7eJbMwogb7J4Z7Yw9x33Od1Nw=QFBU5M8eYg@mail.gmail.com> <1787462.1VlDKmKezL@xps> <BYAPR18MB2424ACF0426C8B5310C6BDA0C8350@BYAPR18MB2424.namprd18.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <BYAPR18MB2424ACF0426C8B5310C6BDA0C8350@BYAPR18MB2424.namprd18.prod.outlook.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190503162503.NxAj33p0cF2GFvGHk4mBgPYc7vpql31Z3KkHKqTQq6s@z> On Fri, May 03, 2019 at 04:01:38PM +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon > > Sent: Thursday, May 2, 2019 9:27 PM > > To: Reshma Pattan <reshma.pattan@intel.com> > > Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com> > > Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 > > > > 02/05/2019 17:00, David Marchand: > > > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan > > > <reshma.pattan@intel.com> > > > wrote: > > > > > > > gcc 9 on Fedora 30 gives an error > > > > "taking address of packed member may result in an unaligned pointer > > > > value" warnings. > > > > > > > > For clang builds this warning is already disabled, so disable > > > > "-Waddress-of-packed-member" for gcc builds also. > > > > > > > > Snippet of build error: > > > > ...lib/librte_eal/linux/eal/eal_memalloc.c: In function ‘alloc_seg_walk’: > > > > ...lib/librte_eal/linux/eal/eal_memalloc.c:768:12: error: taking > > > > address of packed member of ‘struct rte_mem_config’ may result in an > > > > unaligned pointer value [-Werror=address-of-packed-member] > > > > 768 | cur_msl = &mcfg->memsegs[msl_idx]; > > > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > > > > > > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com> > > > > > > > > > > > Tested on rhel-7 and fedora-30. > > > Tested-by: David Marchand <david.marchand@redhat.com> > > > > Applied, thanks > > Its been found that one of the armv7 toolchain treats > -Wno-address-of-packed-member as unrecognized command line option, > Hence armv7 build fails on dpdk.org master now. Not sure it is specific to armv7 or compiler? > > Armv7 is not maintained and I don’t think, it has any use case for DPDK. > If everyone agrees IMO it is better remove the arm 32bit support. > > arm-buildroot-linux-gnueabihf-gcc -v > Using built-in specs. > COLLECT_GCC=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > bin/arm-buildroot-linux-gnueabihf-gcc.br_real > COLLECT_LTO_WRAPPER=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > libexec/gcc/arm-buildroot-linux-gnueabihf/7.3.0/lto-wrapper > Target: arm-buildroot-linux-gnueabihf > Configured with: ./configure > --prefix=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --sysconfdir=/opt/armv7-eabihf--glibc--stable-2018.11-1/etc > --enable-static --target=arm-buildroot-linux-gnueabihf > --with-sysroot=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > arm-buildroot-linux-gnueabihf/sysroot > --disable-__cxa_atexit --with-gnu-ld --disable-libssp --disable-multilib > --with-gmp=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-mpc=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-mpfr=/opt/armv7-eabihf--glibc--stable-2018.11-1 > --with-pkgversion='Buildroot 2018.08.1-00003-g576b333' > --with-bugurl=http://bugs.buildroot.net/ --disable-libquadmath > --enable-tls --disable-libmudflap --enable-threads --without-isl > --without-cloog --disable-decimal-float --with-abi=aa > pcs-linux --with-cpu=cortex-a9 --with-fpu=vfpv3-d16 --with-float=hard > --with-mode=arm --enable-languages=c,c++ > --with-build-time-tools=/opt/armv7-eabihf--glibc--stable-2018.11-1/ > arm-buildroot-linux-gnueabihf/bin --enable-shared --disable-libgomp > Thread model: posix > gcc version 7.3.0 (Buildroot 2018.08.1-00003-g576b333) > > error log: > > dpdk.org/lib/librte_eal/linux/eal/eal_vfio_mp_sync.c: At top level: > cc1: error: unrecognized command line option > ‘-Wno-address-of-packed-member’ [-Werror] > cc1: all warnings being treated as errors > Are you sure there is not another error as well? GCC silently ignores flags like this one normally, but does report them as unrecognised if-and-only-if another error or warning is given too. /Bruce