From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE810A0AC5 for ; Fri, 3 May 2019 19:16:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 145B81B0FB; Fri, 3 May 2019 19:16:35 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 5F3227EC7 for ; Fri, 3 May 2019 19:16:33 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id u34so2273166uau.7 for ; Fri, 03 May 2019 10:16:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1nPzEhcKcdW8kJWvCFPbPxUqozHgQm/2GKXxdf0t5PY=; b=OH/rNK/Hlaz5xVv8R/LvXdlgUBsH6tsDLxzxMerOKpbP4fsqMwc5V6LOAK8h4DH2X/ T6Jkj0qm/HpJGd1Gt4TcJF9nzj9obI7THDzhJDa76EgcZFQ9vSSPf63kA3F0SJSdRh21 dWu5/Ao05u9DwfPrQp2QraQWNyUOp736pDC85qNYjeiS0bXABRh1lq9o5o/Jj/DOTu3I RihQOpNblWTENOCncm75Z0qDRFgJmw2YP/tepEJJPgQnoMBQ7M821rwELWH+mYSOX+Hv S9NZPvmW4I8kWQAurEXodZFfDqp4BU1Jdg+4uzew6grglHl3l4Nyp6s23QsRZNmFcTUv HZTw== X-Gm-Message-State: APjAAAW2mBBYqaumarkCZ66TJOKDG8nOBSOnRy2vT65Rfmtm99CkE87w GLXuugyrCqUWv0nsqNLLLt3akiLp08P/ecUDAjUmLg== X-Google-Smtp-Source: APXvYqwb9cIvLL1UCkqf4GuqBlUkLosBfHc7ygVhVLpdFmHXsrVmy9oy8wBohY49/cgiOCC/xs/ZozOW6E8iaN/n/xc= X-Received: by 2002:ab0:70d3:: with SMTP id r19mr5659043ual.126.1556903792721; Fri, 03 May 2019 10:16:32 -0700 (PDT) MIME-Version: 1.0 References: <1556894060-13573-1-git-send-email-david.marchand@redhat.com> <1556894060-13573-2-git-send-email-david.marchand@redhat.com> <20190503150346.GA32640@hmswarspite.think-freely.org> In-Reply-To: <20190503150346.GA32640@hmswarspite.think-freely.org> From: David Marchand Date: Fri, 3 May 2019 19:16:21 +0200 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503171621.0oS9SmLFdn6lp931us1nSfBL_QTgTf-4YRzuqVJkvsc@z> On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > > Even if rare, the check script should handle removing a section. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > devtools/check-symbol-change.sh | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/devtools/check-symbol-change.sh > b/devtools/check-symbol-change.sh > > index 8da7650..d5fad04 100755 > > --- a/devtools/check-symbol-change.sh > > +++ b/devtools/check-symbol-change.sh > > @@ -32,6 +32,7 @@ build_map_changes() > > # symbol rule below > > /^.*{/ { > > gsub("+", ""); > > + gsub("-", ""); > > if (in_map == 1) { > > sec=$(NF-1); in_sec=1; > > } > > -- > > 1.8.3.1 > > > > > Don't you also need to add some logic in the symbol detection match rule to > print an appropriate indicator that a symbol is being removed? With just > this > change, you will note that you are parsing a section, but you will never > trigger > a symbol match > I do remember seeing a warning about the "-EXPERIMENTAL" section. And this is why I added this. But since then I reorganised my series and eliminated some parts... so you are most likely right. I will double check and repost. -- David Marchand