From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v3 4/5] examples/bond: use lcore accessor
Date: Fri, 3 May 2019 10:25:06 -0700 [thread overview]
Message-ID: <20190503172507.5272-5-stephen@networkplumber.org> (raw)
Message-ID: <20190503172506.douktoUxCdLrxLYiZnFfRVw_Bzl61fRJ2k2QgLqG6zU@z> (raw)
In-Reply-To: <20190503172507.5272-1-stephen@networkplumber.org>
Referring to lcore_config directly is no longer recommended.
Also remove unnecessary assignment of slave_core_id.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
examples/bond/main.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/examples/bond/main.c b/examples/bond/main.c
index ef86194fff4a..1b35d53c8efa 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -526,8 +526,9 @@ static void cmd_start_parsed(__attribute__((unused)) void *parsed_result,
int slave_core_id = rte_lcore_id();
rte_spinlock_trylock(&global_flag_stru_p->lock);
- if (global_flag_stru_p->LcoreMainIsRunning == 0) {
- if (lcore_config[global_flag_stru_p->LcoreMainCore].state != WAIT) {
+ if (global_flag_stru_p->LcoreMainIsRunning == 0) {
+ if (rte_eal_get_lcore_state(global_flag_stru_p->LcoreMainCore)
+ != WAIT) {
rte_spinlock_unlock(&global_flag_stru_p->lock);
return;
}
@@ -760,7 +761,7 @@ static void prompt(__attribute__((unused)) void *arg1)
int
main(int argc, char *argv[])
{
- int ret;
+ int ret, slave_core_id;
uint16_t nb_ports, i;
/* init EAL */
@@ -792,13 +793,13 @@ main(int argc, char *argv[])
bond_port_init(mbuf_pool);
rte_spinlock_init(&global_flag_stru_p->lock);
- int slave_core_id = rte_lcore_id();
/* check state of lcores */
RTE_LCORE_FOREACH_SLAVE(slave_core_id) {
- if (lcore_config[slave_core_id].state != WAIT)
- return -EBUSY;
+ if (rte_eal_get_lcore_state(slave_core_id) != WAIT)
+ return -EBUSY;
}
+
/* start lcore main on core != master_core - ARP response thread */
slave_core_id = rte_get_next_lcore(rte_lcore_id(), 1, 0);
if ((slave_core_id >= RTE_MAX_LCORE) || (slave_core_id == 0))
--
2.20.1
next prev parent reply other threads:[~2019-05-03 17:25 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 18:25 [dpdk-dev] [PATCH v1 0/5] make lcore_config internal Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 1/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 2/5] bus: use lcore accessor functions Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 3/5] examples/bond: use lcore accessor Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 5/5] eal: make lcore_config private Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-10 17:15 ` [dpdk-dev] [PATCH v2 0/5] make lcore_config internal Stephen Hemminger
2019-04-10 17:15 ` Stephen Hemminger
2019-04-10 17:15 ` [dpdk-dev] [PATCH v2 1/5] eal: use unsigned int in rte_lcore.h functions Stephen Hemminger
2019-04-10 17:15 ` Stephen Hemminger
2019-05-03 7:24 ` David Marchand
2019-05-03 7:24 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-04-16 17:03 ` Jerin Jacob Kollanukkaran
2019-04-16 17:03 ` Jerin Jacob Kollanukkaran
2019-04-30 20:53 ` Stephen Hemminger
2019-04-30 20:53 ` Stephen Hemminger
2019-05-01 2:12 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-05-01 2:12 ` Jerin Jacob Kollanukkaran
2019-05-03 7:22 ` [dpdk-dev] " David Marchand
2019-05-03 7:22 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 3/5] bus: use lcore accessor functions Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 4/5] examples/bond: use lcore accessor Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-05-03 7:29 ` David Marchand
2019-05-03 7:29 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 5/5] app/test: use lcore accessor functions Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-05-02 23:15 ` [dpdk-dev] [PATCH v2 0/5] make lcore_config internal Stephen Hemminger
2019-05-02 23:15 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 1/5] eal: use unsigned int in rte_lcore.h functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 2/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 3/5] bus: use lcore accessor functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger [this message]
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 4/5] examples/bond: use lcore accessor Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 5/5] app/test: use lcore accessor functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-06 7:20 ` [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI David Marchand
2019-05-06 7:20 ` David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 0/5] make lcore_config internal David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 1/5] eal: use unsigned int in lcore API prototypes David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors David Marchand
2019-05-29 22:46 ` Thomas Monjalon
2019-05-29 22:51 ` Stephen Hemminger
2019-05-30 7:31 ` David Marchand
2019-05-30 7:40 ` Thomas Monjalon
2019-05-30 10:11 ` Bruce Richardson
2019-05-30 13:39 ` Thomas Monjalon
2019-05-30 17:00 ` David Marchand
2019-05-30 20:08 ` Bruce Richardson
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 3/5] drivers/bus: use " David Marchand
2019-05-23 13:59 ` [dpdk-dev] [PATCH v4 4/5] examples/bond: " David Marchand
2019-05-23 13:59 ` [dpdk-dev] [PATCH v4 5/5] test: " David Marchand
2019-05-23 15:14 ` [dpdk-dev] [PATCH v4 0/5] make lcore_config internal Stephen Hemminger
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 " David Marchand
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 1/5] eal: use unsigned int in lcore API prototypes David Marchand
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 2/5] eal: add lcore accessors David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 3/5] drivers/bus: use " David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 4/5] examples/bond: " David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 5/5] test: " David Marchand
2019-06-04 15:11 ` Eads, Gage
2019-06-03 10:32 ` [dpdk-dev] [PATCH v5 0/5] make lcore_config internal Thomas Monjalon
2019-06-03 20:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503172507.5272-5-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).