Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

[Liron Himi <lironh@marvell.com>]

+1

Regards,
Liron

-----Original Message-----
From: Trahe, Fiona <fiona.trahe@intel.com> 
Sent: Friday, May 3, 2019 9:10 PM
To: Doherty, Declan <declan.doherty@intel.com>; ravi1.kumar@amd.com; tdu@semihalf.com; Liron Himi <lironh@marvell.com>; Alan Winkowski <walan@marvell.com>
Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Anoob Joseph <anoobj@marvell.com>; Shally Verma <shallyv@marvell.com>; akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
Subject: [EXT] RE: [PATCH] doc: add cryptodev gcm iv deprecation notice

External Email

----------------------------------------------------------------------
Forwarding to maintainers of the following crypto PMDs which may be affected by this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed

This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/


> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph <anoobj@marvell.com>; shallyv@marvell.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo 
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX 
> <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
> 
> Hi Anoob/Shally,
> 
> Could you please review this patch and provide Ack.
> 
> Thanks,
> Akhil
> 
> 
> >
> >
> > This patch adds deprecation notice of changing iv behaviour when 
> > using Galois Counter Mode of operation. Right now IV of all 
> > supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> >  * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> >    structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> >    ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still 
> > +can
> > +  be used but only when IV length in following structs 
> > +``rte_crypto_auth_xform``,
> > +  ``rte_crypto_aead_xform`` is set to zero. When IV length is 
> > +greater or equal
> > +  to one it means it represents IV, when is set to zero it means J0 
> > +is used
> > +  directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0