* [dpdk-dev] [PATCH] net/ice: minor code cleanups
@ 2019-05-05 5:45 Xiao Wang
2019-05-05 5:45 ` Xiao Wang
2019-05-06 0:36 ` Zhang, Qi Z
0 siblings, 2 replies; 4+ messages in thread
From: Xiao Wang @ 2019-05-05 5:45 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, qiming.yang, Xiao Wang
This patch is a cleanup on comment, variable modifier, coding style.
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..706632424 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev)
/* disable uio intr before callback unregister */
rte_intr_disable(intr_handle);
- /* register callback func to eal lib */
+ /* unregister callback func from eal lib */
rte_intr_callback_unregister(intr_handle,
ice_interrupt_handler, dev);
@@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
}
static int
-ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
{
#define CHECK_INTERVAL 100 /* 100ms */
#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */
@@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev,
reg_id = 3;
else
reg_id = 5;
- break;
+ break;
case ETH_VLAN_TYPE_INNER:
if (qinq) {
reg_id = 5;
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] net/ice: minor code cleanups
2019-05-05 5:45 [dpdk-dev] [PATCH] net/ice: minor code cleanups Xiao Wang
@ 2019-05-05 5:45 ` Xiao Wang
2019-05-06 0:36 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Xiao Wang @ 2019-05-05 5:45 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, qiming.yang, Xiao Wang
This patch is a cleanup on comment, variable modifier, coding style.
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..706632424 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev)
/* disable uio intr before callback unregister */
rte_intr_disable(intr_handle);
- /* register callback func to eal lib */
+ /* unregister callback func from eal lib */
rte_intr_callback_unregister(intr_handle,
ice_interrupt_handler, dev);
@@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
}
static int
-ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
{
#define CHECK_INTERVAL 100 /* 100ms */
#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */
@@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev,
reg_id = 3;
else
reg_id = 5;
- break;
+ break;
case ETH_VLAN_TYPE_INNER:
if (qinq) {
reg_id = 5;
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: minor code cleanups
2019-05-05 5:45 [dpdk-dev] [PATCH] net/ice: minor code cleanups Xiao Wang
2019-05-05 5:45 ` Xiao Wang
@ 2019-05-06 0:36 ` Zhang, Qi Z
2019-05-06 0:36 ` Zhang, Qi Z
1 sibling, 1 reply; 4+ messages in thread
From: Zhang, Qi Z @ 2019-05-06 0:36 UTC (permalink / raw)
To: Wang, Xiao W, Lu, Wenzhuo; +Cc: dev, Yang, Qiming, Wang, Xiao W
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> Sent: Sunday, May 5, 2019 1:45 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: minor code cleanups
>
> This patch is a cleanup on comment, variable modifier, coding style.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: minor code cleanups
2019-05-06 0:36 ` Zhang, Qi Z
@ 2019-05-06 0:36 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2019-05-06 0:36 UTC (permalink / raw)
To: Wang, Xiao W, Lu, Wenzhuo; +Cc: dev, Yang, Qiming, Wang, Xiao W
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> Sent: Sunday, May 5, 2019 1:45 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: minor code cleanups
>
> This patch is a cleanup on comment, variable modifier, coding style.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-06 0:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 5:45 [dpdk-dev] [PATCH] net/ice: minor code cleanups Xiao Wang
2019-05-05 5:45 ` Xiao Wang
2019-05-06 0:36 ` Zhang, Qi Z
2019-05-06 0:36 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).