Re: [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI

[David Marchand <david.marchand@redhat.com>]

On Fri, May 3, 2019 at 7:25 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> This set of patches makes the lcore_config structure less visible
> as part of the ABI.  This version does not break the ABI (yet)
> follow on patch moves lcore_config into eal_private.h
>
> Changes for v3 (based on David's feedback):
>   - rte_lcore_index should not be experimental
>   - eal map should chain from 18.11
>   - more fixes in bond example
>
> Stephen Hemminger (5):
>   eal: use unsigned int in rte_lcore.h functions
>   eal: add accessor functions for lcore_config
>   bus: use lcore accessor functions
>   examples/bond: use lcore accessor
>   app/test: use lcore accessor functions
>
>  app/test/test_cryptodev.c                 |  2 +-
>  app/test/test_hash_readwrite_lf.c         | 14 +++---
>  app/test/test_ring_perf.c                 | 22 +++++----
>  app/test/test_stack_perf.c                | 20 ++++----
>  doc/guides/rel_notes/release_19_05.rst    |  6 +++
>  drivers/bus/dpaa/dpaa_bus.c               |  6 ++-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
>  examples/bond/main.c                      | 13 +++---
>  lib/librte_eal/common/eal_common_lcore.c  | 39 ++++++++++++++++
>  lib/librte_eal/common/include/rte_lcore.h | 57 ++++++++++++++++-------
>  lib/librte_eal/rte_eal_version.map        | 11 +++++
>  11 files changed, 139 insertions(+), 55 deletions(-)
>
> --
> 2.20.1
>
>
LGTM.

-- 
David Marchand