From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 7A2DFA0096
	for <public@inbox.dpdk.org>; Mon,  6 May 2019 09:20:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 99D2432A5;
	Mon,  6 May 2019 09:20:53 +0200 (CEST)
Received: from mail-vk1-f193.google.com (mail-vk1-f193.google.com
 [209.85.221.193]) by dpdk.org (Postfix) with ESMTP id A5EC92BBB
 for <dev@dpdk.org>; Mon,  6 May 2019 09:20:51 +0200 (CEST)
Received: by mail-vk1-f193.google.com with SMTP id d74so2925863vka.3
 for <dev@dpdk.org>; Mon, 06 May 2019 00:20:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=F3OyYLbQ8XMBjtQeBO9zphPwHlJ5eKfd6jdjTGUEzSI=;
 b=DQb/Q/9ekeD8KYn4jxM+gYZ+KwWhx6bJDezvEi2q1kKp/TFf+FzbDzXXBwZIOG85Nu
 2V0Napc45O99kZIfrkNr6j/TR2Keh5U5BwSlwHHDRQby5jQprj35133Gkr2zWNd42DGO
 Vi2EM2fS8jnV/vg2w5y9B1v6RWpmiVsGaK6CIhZVdwVpNBa8xZf/0QBL6jIXYaYYLeNg
 zDQeVj7DHalFtziZWG0JWjtXfs5JswHhU08aJxYGuGCayf5QjszbCCyElm6EjRc813cr
 F8CfDNslJ7HFiyVp4AC2hS8DJCmWeoTgpFMlG904+L7Vr8vrPKWfuNkHdTFN9z7jr+gu
 8gtw==
X-Gm-Message-State: APjAAAWVnLS0AXvXZG2uwATj407iLZiVak7r8zZrrkkWhxXoGcze3G9m
 YRVt8wDxu0JyaEdWBY1en64LsTpKJP/B7j/+TC7oPQR2
X-Google-Smtp-Source: APXvYqzh4fU6E+0CFOPkH6JxUc+K9YHNF81Bih7zrB0dPKwqIAoTE3vrRKHefW3mVQnqO75S1xI1+k2QgjJr3tqu49Y=
X-Received: by 2002:a1f:8dcc:: with SMTP id p195mr12003322vkd.31.1557127250527; 
 Mon, 06 May 2019 00:20:50 -0700 (PDT)
MIME-Version: 1.0
References: <20190410171603.8979-1-stephen@networkplumber.org>
 <20190503172507.5272-1-stephen@networkplumber.org>
In-Reply-To: <20190503172507.5272-1-stephen@networkplumber.org>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 6 May 2019 09:20:39 +0200
Message-ID:
 <CAJFAV8zr+yPLCnM-uTeeEraVwB+q7tc_vXiaCV0pXftCMGR+1A@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not
 visible in ABI
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190506072039.FCTm06IrumCUUvOZBpUn-qE6A5_Z1kEqAXCTKHN3_vk@z>

On Fri, May 3, 2019 at 7:25 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> This set of patches makes the lcore_config structure less visible
> as part of the ABI.  This version does not break the ABI (yet)
> follow on patch moves lcore_config into eal_private.h
>
> Changes for v3 (based on David's feedback):
>   - rte_lcore_index should not be experimental
>   - eal map should chain from 18.11
>   - more fixes in bond example
>
> Stephen Hemminger (5):
>   eal: use unsigned int in rte_lcore.h functions
>   eal: add accessor functions for lcore_config
>   bus: use lcore accessor functions
>   examples/bond: use lcore accessor
>   app/test: use lcore accessor functions
>
>  app/test/test_cryptodev.c                 |  2 +-
>  app/test/test_hash_readwrite_lf.c         | 14 +++---
>  app/test/test_ring_perf.c                 | 22 +++++----
>  app/test/test_stack_perf.c                | 20 ++++----
>  doc/guides/rel_notes/release_19_05.rst    |  6 +++
>  drivers/bus/dpaa/dpaa_bus.c               |  6 ++-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
>  examples/bond/main.c                      | 13 +++---
>  lib/librte_eal/common/eal_common_lcore.c  | 39 ++++++++++++++++
>  lib/librte_eal/common/include/rte_lcore.h | 57 ++++++++++++++++-------
>  lib/librte_eal/rte_eal_version.map        | 11 +++++
>  11 files changed, 139 insertions(+), 55 deletions(-)
>
> --
> 2.20.1
>
>
LGTM.

-- 
David Marchand