* [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function
@ 2019-05-06 8:44 Xiao Wang
2019-05-06 8:44 ` Xiao Wang
2019-05-14 14:57 ` Zhang, Qi Z
0 siblings, 2 replies; 4+ messages in thread
From: Xiao Wang @ 2019-05-06 8:44 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, ferruh.yigit, Xiao Wang, stable
PMD should advertise supported RSS hash functions via
dev_info.flow_type_rss_offloads variable [1], otherwise upper level check
would fail on configuring RSS, leading to MQ RSS failure.
[1] commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
Cc: stable@dpdk.org
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index caf4d1bc0..f64d07bba 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -1389,6 +1389,15 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
dev_info->hash_key_size = FM10K_RSSRK_SIZE * sizeof(uint32_t);
dev_info->reta_size = FM10K_MAX_RSS_INDICES;
+ dev_info->flow_type_rss_offloads = ETH_RSS_IPV4 |
+ ETH_RSS_IPV6 |
+ ETH_RSS_IPV6_EX |
+ ETH_RSS_NONFRAG_IPV4_TCP |
+ ETH_RSS_NONFRAG_IPV6_TCP |
+ ETH_RSS_IPV6_TCP_EX |
+ ETH_RSS_NONFRAG_IPV4_UDP |
+ ETH_RSS_NONFRAG_IPV6_UDP |
+ ETH_RSS_IPV6_UDP_EX;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function
2019-05-06 8:44 [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function Xiao Wang
@ 2019-05-06 8:44 ` Xiao Wang
2019-05-14 14:57 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Xiao Wang @ 2019-05-06 8:44 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, ferruh.yigit, Xiao Wang, stable
PMD should advertise supported RSS hash functions via
dev_info.flow_type_rss_offloads variable [1], otherwise upper level check
would fail on configuring RSS, leading to MQ RSS failure.
[1] commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
Cc: stable@dpdk.org
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index caf4d1bc0..f64d07bba 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -1389,6 +1389,15 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
dev_info->hash_key_size = FM10K_RSSRK_SIZE * sizeof(uint32_t);
dev_info->reta_size = FM10K_MAX_RSS_INDICES;
+ dev_info->flow_type_rss_offloads = ETH_RSS_IPV4 |
+ ETH_RSS_IPV6 |
+ ETH_RSS_IPV6_EX |
+ ETH_RSS_NONFRAG_IPV4_TCP |
+ ETH_RSS_NONFRAG_IPV6_TCP |
+ ETH_RSS_IPV6_TCP_EX |
+ ETH_RSS_NONFRAG_IPV4_UDP |
+ ETH_RSS_NONFRAG_IPV6_UDP |
+ ETH_RSS_IPV6_UDP_EX;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function
2019-05-06 8:44 [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function Xiao Wang
2019-05-06 8:44 ` Xiao Wang
@ 2019-05-14 14:57 ` Zhang, Qi Z
2019-05-14 14:57 ` Zhang, Qi Z
1 sibling, 1 reply; 4+ messages in thread
From: Zhang, Qi Z @ 2019-05-14 14:57 UTC (permalink / raw)
To: Wang, Xiao W; +Cc: dev, Yigit, Ferruh, stable
> -----Original Message-----
> From: Wang, Xiao W
> Sent: Monday, May 6, 2019 4:45 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/fm10k: advertise supported RSS hash function
>
> PMD should advertise supported RSS hash functions via
> dev_info.flow_type_rss_offloads variable [1], otherwise upper level check
> would fail on configuring RSS, leading to MQ RSS failure.
>
> [1] commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function
2019-05-14 14:57 ` Zhang, Qi Z
@ 2019-05-14 14:57 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2019-05-14 14:57 UTC (permalink / raw)
To: Wang, Xiao W; +Cc: dev, Yigit, Ferruh, stable
> -----Original Message-----
> From: Wang, Xiao W
> Sent: Monday, May 6, 2019 4:45 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/fm10k: advertise supported RSS hash function
>
> PMD should advertise supported RSS hash functions via
> dev_info.flow_type_rss_offloads variable [1], otherwise upper level check
> would fail on configuring RSS, leading to MQ RSS failure.
>
> [1] commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-14 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 8:44 [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function Xiao Wang
2019-05-06 8:44 ` Xiao Wang
2019-05-14 14:57 ` Zhang, Qi Z
2019-05-14 14:57 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).