From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id ADF683DC; Mon, 6 May 2019 17:43:48 +0200 (CEST) Received: from cpe-2606-a000-111b-405a-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:405a::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hNfmJ-0002zM-HB; Mon, 06 May 2019 11:43:45 -0400 Date: Mon, 6 May 2019 11:43:14 -0400 From: Neil Horman To: David Marchand Cc: dev , Thomas Monjalon , dpdk stable Message-ID: <20190506154314.GA32063@hmswarspite.think-freely.org> References: <1556894060-13573-1-git-send-email-david.marchand@redhat.com> <1556894060-13573-2-git-send-email-david.marchand@redhat.com> <20190503150346.GA32640@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 15:43:49 -0000 On Mon, May 06, 2019 at 02:56:51PM +0200, David Marchand wrote: > On Fri, May 3, 2019 at 7:16 PM David Marchand > wrote: > > > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > > > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > >> > Even if rare, the check script should handle removing a section. > >> > > >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > >> > Cc: stable@dpdk.org > >> > > >> > Signed-off-by: David Marchand > >> > --- > >> > devtools/check-symbol-change.sh | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> > diff --git a/devtools/check-symbol-change.sh > >> b/devtools/check-symbol-change.sh > >> > index 8da7650..d5fad04 100755 > >> > --- a/devtools/check-symbol-change.sh > >> > +++ b/devtools/check-symbol-change.sh > >> > @@ -32,6 +32,7 @@ build_map_changes() > >> > # symbol rule below > >> > /^.*{/ { > >> > gsub("+", ""); > >> > + gsub("-", ""); > >> > if (in_map == 1) { > >> > sec=$(NF-1); in_sec=1; > >> > } > >> > -- > >> > 1.8.3.1 > >> > > >> > > >> Don't you also need to add some logic in the symbol detection match rule > >> to > >> print an appropriate indicator that a symbol is being removed? With just > >> this > >> change, you will note that you are parsing a section, but you will never > >> trigger > >> a symbol match > >> > > > > I do remember seeing a warning about the "-EXPERIMENTAL" section. > > And this is why I added this. > > But since then I reorganised my series and eliminated some parts... so you > > are most likely right. > > I will double check and repost. > > > > > Yes, you are right, I moved this out of another patch that I ended up not > sending. > But it makes no sense by itself. > I will drop this in v2. > > Any comments on the other patches ? > Thanks Neil. > No, I don't think I do, thanks for checking though! Neil > > -- > David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E76D2A0096 for ; Mon, 6 May 2019 17:43:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 538432082; Mon, 6 May 2019 17:43:50 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id ADF683DC; Mon, 6 May 2019 17:43:48 +0200 (CEST) Received: from cpe-2606-a000-111b-405a-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:405a::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hNfmJ-0002zM-HB; Mon, 06 May 2019 11:43:45 -0400 Date: Mon, 6 May 2019 11:43:14 -0400 From: Neil Horman To: David Marchand Cc: dev , Thomas Monjalon , dpdk stable Message-ID: <20190506154314.GA32063@hmswarspite.think-freely.org> References: <1556894060-13573-1-git-send-email-david.marchand@redhat.com> <1556894060-13573-2-git-send-email-david.marchand@redhat.com> <20190503150346.GA32640@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190506154314.2i_k7Qi7rMFHwH1wVro7Eje5X-_10bMKTpZUqXnKHCs@z> On Mon, May 06, 2019 at 02:56:51PM +0200, David Marchand wrote: > On Fri, May 3, 2019 at 7:16 PM David Marchand > wrote: > > > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > > > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > >> > Even if rare, the check script should handle removing a section. > >> > > >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > >> > Cc: stable@dpdk.org > >> > > >> > Signed-off-by: David Marchand > >> > --- > >> > devtools/check-symbol-change.sh | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> > diff --git a/devtools/check-symbol-change.sh > >> b/devtools/check-symbol-change.sh > >> > index 8da7650..d5fad04 100755 > >> > --- a/devtools/check-symbol-change.sh > >> > +++ b/devtools/check-symbol-change.sh > >> > @@ -32,6 +32,7 @@ build_map_changes() > >> > # symbol rule below > >> > /^.*{/ { > >> > gsub("+", ""); > >> > + gsub("-", ""); > >> > if (in_map == 1) { > >> > sec=$(NF-1); in_sec=1; > >> > } > >> > -- > >> > 1.8.3.1 > >> > > >> > > >> Don't you also need to add some logic in the symbol detection match rule > >> to > >> print an appropriate indicator that a symbol is being removed? With just > >> this > >> change, you will note that you are parsing a section, but you will never > >> trigger > >> a symbol match > >> > > > > I do remember seeing a warning about the "-EXPERIMENTAL" section. > > And this is why I added this. > > But since then I reorganised my series and eliminated some parts... so you > > are most likely right. > > I will double check and repost. > > > > > Yes, you are right, I moved this out of another patch that I ended up not > sending. > But it makes no sense by itself. > I will drop this in v2. > > Any comments on the other patches ? > Thanks Neil. > No, I don't think I do, thanks for checking though! Neil > > -- > David Marchand