* [dpdk-dev] [PATCH] net/ice: set min and max MTU
@ 2019-05-04 9:45 Qi Zhang
2019-05-04 9:45 ` Qi Zhang
2019-05-06 17:39 ` Stillwell Jr, Paul M
0 siblings, 2 replies; 6+ messages in thread
From: Qi Zhang @ 2019-05-04 9:45 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang; +Cc: ian.stokes, ferruh.yigit, dev, Qi Zhang
This commit sets the min and max supported MTU values for ice devices
via the i40e_dev_info_get() function. Min MTU supported is set to
ETHER_MIN_MTU and max mtu is calculated as the max packet length
supported minus the transport overhead.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..9f5f919f4 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->max_tx_queues = vsi->nb_qps;
dev_info->max_mac_addrs = vsi->max_macaddrs;
dev_info->max_vfs = pci_dev->max_vfs;
+ dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+ dev_info->min_mtu = ETHER_MIN_MTU;
dev_info->rx_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] net/ice: set min and max MTU
2019-05-04 9:45 [dpdk-dev] [PATCH] net/ice: set min and max MTU Qi Zhang
@ 2019-05-04 9:45 ` Qi Zhang
2019-05-06 17:39 ` Stillwell Jr, Paul M
1 sibling, 0 replies; 6+ messages in thread
From: Qi Zhang @ 2019-05-04 9:45 UTC (permalink / raw)
To: wenzhuo.lu, qiming.yang; +Cc: ian.stokes, ferruh.yigit, dev, Qi Zhang
This commit sets the min and max supported MTU values for ice devices
via the i40e_dev_info_get() function. Min MTU supported is set to
ETHER_MIN_MTU and max mtu is calculated as the max packet length
supported minus the transport overhead.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..9f5f919f4 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->max_tx_queues = vsi->nb_qps;
dev_info->max_mac_addrs = vsi->max_macaddrs;
dev_info->max_vfs = pci_dev->max_vfs;
+ dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+ dev_info->min_mtu = ETHER_MIN_MTU;
dev_info->rx_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU
2019-05-04 9:45 [dpdk-dev] [PATCH] net/ice: set min and max MTU Qi Zhang
2019-05-04 9:45 ` Qi Zhang
@ 2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 23:10 ` Zhang, Qi Z
1 sibling, 2 replies; 6+ messages in thread
From: Stillwell Jr, Paul M @ 2019-05-06 17:39 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo, Yang, Qiming
Cc: Stokes, Ian, Yigit, Ferruh, dev, Zhang, Qi Z
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Saturday, May 4, 2019 2:46 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU
>
> This commit sets the min and max supported MTU values for ice devices via the
> i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU
Should this be ice_dev_info_get()?
> and max mtu is calculated as the max packet length supported minus the
> transport overhead.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 1f06a2c80..9f5f919f4 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> dev_info->max_tx_queues = vsi->nb_qps;
> dev_info->max_mac_addrs = vsi->max_macaddrs;
> dev_info->max_vfs = pci_dev->max_vfs;
> + dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
> + dev_info->min_mtu = ETHER_MIN_MTU;
>
> dev_info->rx_offload_capa =
> DEV_RX_OFFLOAD_VLAN_STRIP |
> --
> 2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU
2019-05-06 17:39 ` Stillwell Jr, Paul M
@ 2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 23:10 ` Zhang, Qi Z
1 sibling, 0 replies; 6+ messages in thread
From: Stillwell Jr, Paul M @ 2019-05-06 17:39 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo, Yang, Qiming
Cc: Stokes, Ian, Yigit, Ferruh, dev, Zhang, Qi Z
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Saturday, May 4, 2019 2:46 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU
>
> This commit sets the min and max supported MTU values for ice devices via the
> i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU
Should this be ice_dev_info_get()?
> and max mtu is calculated as the max packet length supported minus the
> transport overhead.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 1f06a2c80..9f5f919f4 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> dev_info->max_tx_queues = vsi->nb_qps;
> dev_info->max_mac_addrs = vsi->max_macaddrs;
> dev_info->max_vfs = pci_dev->max_vfs;
> + dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
> + dev_info->min_mtu = ETHER_MIN_MTU;
>
> dev_info->rx_offload_capa =
> DEV_RX_OFFLOAD_VLAN_STRIP |
> --
> 2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU
2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 17:39 ` Stillwell Jr, Paul M
@ 2019-05-06 23:10 ` Zhang, Qi Z
2019-05-06 23:10 ` Zhang, Qi Z
1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2019-05-06 23:10 UTC (permalink / raw)
To: Stillwell Jr, Paul M, Lu, Wenzhuo, Yang, Qiming
Cc: Stokes, Ian, Yigit, Ferruh, dev
> -----Original Message-----
> From: Stillwell Jr, Paul M
> Sent: Tuesday, May 7, 2019 1:39 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ice: set min and max MTU
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> > Sent: Saturday, May 4, 2019 2:46 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; dev@dpdk.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU
> >
> > This commit sets the min and max supported MTU values for ice devices
> > via the
> > i40e_dev_info_get() function. Min MTU supported is set to
> > ETHER_MIN_MTU
>
> Should this be ice_dev_info_get()?
Ah yes, will fix in v2, thanks
>
> > and max mtu is calculated as the max packet length supported minus the
> > transport overhead.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c
> > b/drivers/net/ice/ice_ethdev.c index
> > 1f06a2c80..9f5f919f4 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct
> > rte_eth_dev_info *dev_info)
> > dev_info->max_tx_queues = vsi->nb_qps;
> > dev_info->max_mac_addrs = vsi->max_macaddrs;
> > dev_info->max_vfs = pci_dev->max_vfs;
> > + dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
> > + dev_info->min_mtu = ETHER_MIN_MTU;
> >
> > dev_info->rx_offload_capa =
> > DEV_RX_OFFLOAD_VLAN_STRIP |
> > --
> > 2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: set min and max MTU
2019-05-06 23:10 ` Zhang, Qi Z
@ 2019-05-06 23:10 ` Zhang, Qi Z
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2019-05-06 23:10 UTC (permalink / raw)
To: Stillwell Jr, Paul M, Lu, Wenzhuo, Yang, Qiming
Cc: Stokes, Ian, Yigit, Ferruh, dev
> -----Original Message-----
> From: Stillwell Jr, Paul M
> Sent: Tuesday, May 7, 2019 1:39 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ice: set min and max MTU
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> > Sent: Saturday, May 4, 2019 2:46 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Cc: Stokes, Ian <ian.stokes@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; dev@dpdk.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU
> >
> > This commit sets the min and max supported MTU values for ice devices
> > via the
> > i40e_dev_info_get() function. Min MTU supported is set to
> > ETHER_MIN_MTU
>
> Should this be ice_dev_info_get()?
Ah yes, will fix in v2, thanks
>
> > and max mtu is calculated as the max packet length supported minus the
> > transport overhead.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c
> > b/drivers/net/ice/ice_ethdev.c index
> > 1f06a2c80..9f5f919f4 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct
> > rte_eth_dev_info *dev_info)
> > dev_info->max_tx_queues = vsi->nb_qps;
> > dev_info->max_mac_addrs = vsi->max_macaddrs;
> > dev_info->max_vfs = pci_dev->max_vfs;
> > + dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
> > + dev_info->min_mtu = ETHER_MIN_MTU;
> >
> > dev_info->rx_offload_capa =
> > DEV_RX_OFFLOAD_VLAN_STRIP |
> > --
> > 2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-06 23:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-04 9:45 [dpdk-dev] [PATCH] net/ice: set min and max MTU Qi Zhang
2019-05-04 9:45 ` Qi Zhang
2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 17:39 ` Stillwell Jr, Paul M
2019-05-06 23:10 ` Zhang, Qi Z
2019-05-06 23:10 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).