From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B28E6A0096 for ; Tue, 7 May 2019 09:59:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B1DD2BB8; Tue, 7 May 2019 09:59:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 7B5041D7; Tue, 7 May 2019 09:59:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x477tggp015366; Tue, 7 May 2019 00:59:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=yNrSb9KY3SQpOkTbZYknZgQTP1Fop5WKzxYpKmR/IQo=; b=ZX0dzxo5EibxSn26/+Poa5h/zi3NmKvCTVZRp2L8upRtY4YPTTe5ayOeDLQrhm+oD4K5 Z7GftNhUiZQKOhwgfiQGfuGDJAdY9xxbQ22pJhq5ro+LyPdAQh+yTUqXXHZaoNWJa1ZV KoMsIfuFig61HK4Jl1Neto+TsbGfd1+BfJxRlI0lY8zaOk2VILxfEYmeh7O82AI4IN0y iEZASPrxPjVIFPGpATpB6gzbKho0Ppo3Qguitu5AWKM8ABtEbYc//NOsLVm2ylp8zeOW 49aoDECp4bSuclr2bqvUQtXt9QuJp6XZ4wcWVfMgZE7937lTtF7wuaDUH8NvsJocYmlg qg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2sb40c0n6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 07 May 2019 00:59:20 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 7 May 2019 00:59:20 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.53) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 7 May 2019 00:59:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yNrSb9KY3SQpOkTbZYknZgQTP1Fop5WKzxYpKmR/IQo=; b=lUSYxVRcsTm4WaR+DXuP/lVop6fAiBCZaVLTt6hftjmW3K5r/PuLLjQVaDd+yZhcOQ9lvMj335x2v4xmaTZtvsZWPeL/HeQ2f8UJr1ihNBs0CDOqc09dS2cUe3itLNYi8zCCAbuME474J9Q7XHkKGlUcQZ/PhhWfpjNLqFcj18w= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2501.namprd18.prod.outlook.com (20.179.92.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Tue, 7 May 2019 07:59:14 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d%3]) with mapi id 15.20.1856.012; Tue, 7 May 2019 07:59:14 +0000 From: Jerin Jacob Kollanukkaran To: Yongseok Koh , Honnappa Nagarahalli CC: Thomas Monjalon , "dev@dpdk.org" , "bruce.richardson@intel.com" , "Pavan Nikhilesh Bhagavatula" , Shahaf Shuler , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Luca Boccassi , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAcE34j6F5Vu/0kWMIbwj+2gTIqZZkgaAgAAb7oCABPj1AIAAqO3g Date: Tue, 7 May 2019 07:59:14 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6eb398ec-d3b5-45e0-02b1-08d6d2c1e5df x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2501; x-ms-traffictypediagnostic: BYAPR18MB2501: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0030839EEE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(136003)(396003)(366004)(189003)(199004)(13464003)(11346002)(229853002)(476003)(4326008)(55016002)(446003)(86362001)(73956011)(8676002)(7416002)(478600001)(99286004)(486006)(54906003)(53546011)(110136005)(7696005)(6506007)(33656002)(5660300002)(256004)(6436002)(102836004)(55236004)(25786009)(316002)(52536014)(68736007)(186003)(26005)(71200400001)(71190400001)(66446008)(9686003)(66476007)(66946007)(64756008)(66556008)(2906002)(76176011)(81156014)(53936002)(8936002)(81166006)(7736002)(6246003)(66066001)(74316002)(305945005)(14454004)(76116006)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2501; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: iSxLENcLw8+CehTdR8jxioZ4ZtgtkbVqfYBcG73y5Ugo5+8c1Bp70v6KWvqCPraJ7dFQN+Ary3iXLZGCAjhpM3Hia2qxQ/LfRVjQiDucjJzHLnWFayUJXf9IUOxOLVCFqkRkEo120PptPNWoSHCMbcMmFjeS0nyY9tsVqpJI7ciVvHJZDX8rdJvXZivY/6f3DLJHXOK1jPru9xD2OnHp9ly7IsPTPmNNyEe0fGVlGTJhWu4xW9R349W44RBjIC/jXELhR1LB9QRVPsPjJVBW1/0TlLdzPWakwbJIdn0QL90LlGd0l/leYi0t0H9p+TqDd8MNU125c56q9+RiuXryGzb81Mw3t2bqySRx7twiDRn8KaEx7Ev3crofDvPpXbcoz8ydaTgZ31bUVdX6J1H9YUAhisgxtXiKaB5reXzjmMA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb398ec-d3b5-45e0-02b1-08d6d2c1e5df X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 07:59:14.4991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2501 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-07_04:, , signatures=0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190507075914.YxTXs1TGEYFsyF9vOLJ9UiT6hyYtSeXzk5IBlVibTgc@z> > -----Original Message----- > From: Yongseok Koh > Sent: Tuesday, May 7, 2019 3:17 AM > To: Honnappa Nagarahalli > Cc: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; dev@dpdk.org; bruce.richardson@intel.com; > Pavan Nikhilesh Bhagavatula ; Shahaf Shuler > ; Gavin Hu (Arm Technology China) > ; stable@dpdk.org; Luca Boccassi > ; nd > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 crypto > extension >=20 > > On May 3, 2019, at 10:50 AM, Yongseok Koh > wrote: > > > >> I think this change might have an impact on the existing users. Does > >> this change need to be documented somewhere (at least in the release > notes)? > > > > Practically, there would be no impact. Even if user's app makes use of > > crypto instructions, the build config of the app should have the flag. >=20 > On IRC, I could see you concerned about the case where user app derives > build flags from DPDK like apps under the examples directory. Yes, that's= a > valid concern. Is there any DPDK example application would depend on the armv8 crypto flag= s? IMO, None of the applications are directly using armv8 crypto instruction. Even such as = comes for any external DPDK app which is not in dpdk.org tree then it can be added in APP makefile. IMO, app writes should be aware of the need for using +crypto if he/she usi= ng the crypto instruction. >=20 > Thomas/Jerin, where could be the best spot to document it? Just release > note? > I think release note would be fine.