From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 64D14A0096 for ; Tue, 7 May 2019 12:09:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 657E3A49; Tue, 7 May 2019 12:09:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AEB7A239 for ; Tue, 7 May 2019 12:09:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 03:09:31 -0700 X-ExtLoop1: 1 Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.36]) ([10.237.221.36]) by fmsmga006.fm.intel.com with ESMTP; 07 May 2019 03:09:29 -0700 To: Andrew Rybchenko , Thomas Monjalon Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , WenjieX A Li References: <20190424220309.84270-1-ferruh.yigit@intel.com> <2207858.tCSXyMIbcb@xps> <1873539.KBY3f8jFuF@xps> <34775dd7-e426-7464-02e9-8fa8730c0cfe@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Tue, 7 May 2019 11:09:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <34775dd7-e426-7464-02e9-8fa8730c0cfe@solarflare.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190507100928.pOyue5JiSaPL-NSHiueAU3HlgisgF9bYynJGpTjyvMw@z> On 5/6/2019 9:09 AM, Andrew Rybchenko wrote: > On 5/4/19 11:45 PM, Thomas Monjalon wrote: >> 02/05/2019 22:27, Thomas Monjalon: >>> 02/05/2019 20:31, Ferruh Yigit: >>>> On 4/29/2019 10:52 AM, Thomas Monjalon wrote: >>>>> 25/04/2019 17:27, Ferruh Yigit: >>>>>> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: >>>>>>> 25/04/2019 13:47, Ferruh Yigit: >>>>>>>> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: >>>>>>>>> 25/04/2019 00:03, Ferruh Yigit: >>>>>>>>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. >>>>>>>>>> >>>>>>>>>> Not all PMDs support the fixed link speed set, and link speed can be set >>>>>>>>>> even with auto negotiation enabled. Reverting the patch to not break >>>>>>>>>> existing usage. >>>>>>>>> Which PMDs do not support this flag? >>>>>>>>> Why not fixing the PMDs? >>>>>>>>> >>>>>>>> At least ixgbe and i40e is not supporting setting a fixed speed. >>>>>>>> But I am not sure if this is something to fix, the command in testpmd is to set >>>>>>>> the link speed, what is the problem with setting the link speed without >>>>>>>> disabling the auto-negotiation? >>>>>>> It means it will negotiate with only one speed proposed. >>>>>> Yes. >>>>>> >>>>>>> The real issue is to not support the fixed flag. >>>>>> I don't know if this is a real issue but >>>>>> even it is, is it an issue in the scope of this testpmd command? >>>>>> >>>>>> right now we are first updating the command to set fixed speed flag, and >>>>>> requesting PMDs to fix for it, I am suggesting not to update the command at all. >>>>> I understand. But this change shows a broken behaviour. >>>>> This is the intent of testpmd to show what works or not in PMDs. >>>>> How hard is it to fix the PMDs in your opinion? >>>>> >>>> As far as I can see the the fixed link speed set is not supported in the PMD. >>>> >>>> It may be easy to add perhaps, I don't know, but is it really a "broken >>>> behavior" to not have this support? >>>> What defines that setting speed has to be "fixed speed", if this demand is not >>>> there, should testpmd enforce it? >>> I think a PMD should support both: fixed or not. >>> >>>> In mail thread we have talked that this testpmd command can get an extra >>>> argument to define the speed fixed or not, this can be used to test fixed speed >>>> by who wants to test/use fixed speed. >>>> >>>> I am for reverting this for the release, and adding a new version next release >>>> with fixed speed argument, otherwise testpmd won't be used to set the speed for >>>> some PMDs. >>> OK >> We could have an option in testpmd to test ETH_LINK_SPEED_FIXED. >> >> Revert applied. > > I agree that revert is the best option for the release, but not long term. > > Typical options are (in order): >  1. Auto-negotiation of whatever port supports >  2. Fixed exactly one speed with autoneg disabled >  3. Auto-negotiation with limitations (and it is really the third option which > makes sense if and only if interface allows to specify more than one speed to be > negotiated) > > Right now testpmd supports (1) and (3) with limitation to only one speed to be > negotiated. I think it is wrong. +1 to not leave this revert as it is for long term, what do you think for: 1) Implement 'fixed' link speed support in the missing drivers. 2) Send a new version of the testpmd patch with a "fixed" argument, so that we can support all three above