* [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
@ 2019-05-06 23:21 Yongseok Koh
2019-05-06 23:21 ` Yongseok Koh
2019-05-08 4:44 ` Shahaf Shuler
0 siblings, 2 replies; 4+ messages in thread
From: Yongseok Koh @ 2019-05-06 23:21 UTC (permalink / raw)
To: shahafs; +Cc: dev, stable
Currently, the name of MPRQ mempool is set by
snprintf(name, sizeof(name), "%s-mprq", dev->device->name);
For port representor, the name is duplicate of its master and failed to
create such a mempool having the same name. Port ID is used in the name
instead.
Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0a4c02e71e..85e6f29188 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1272,7 +1272,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev)
return -rte_errno;
}
}
- snprintf(name, sizeof(name), "%s-mprq", dev->device->name);
+ snprintf(name, sizeof(name), "port-%u-mprq", dev->data->port_id);
mp = rte_mempool_create(name, obj_num, obj_size, MLX5_MPRQ_MP_CACHE_SZ,
0, NULL, NULL, mlx5_mprq_buf_init, NULL,
dev->device->numa_node, 0);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
2019-05-06 23:21 [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name Yongseok Koh
@ 2019-05-06 23:21 ` Yongseok Koh
2019-05-08 4:44 ` Shahaf Shuler
1 sibling, 0 replies; 4+ messages in thread
From: Yongseok Koh @ 2019-05-06 23:21 UTC (permalink / raw)
To: shahafs; +Cc: dev, stable
Currently, the name of MPRQ mempool is set by
snprintf(name, sizeof(name), "%s-mprq", dev->device->name);
For port representor, the name is duplicate of its master and failed to
create such a mempool having the same name. Port ID is used in the name
instead.
Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0a4c02e71e..85e6f29188 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1272,7 +1272,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev)
return -rte_errno;
}
}
- snprintf(name, sizeof(name), "%s-mprq", dev->device->name);
+ snprintf(name, sizeof(name), "port-%u-mprq", dev->data->port_id);
mp = rte_mempool_create(name, obj_num, obj_size, MLX5_MPRQ_MP_CACHE_SZ,
0, NULL, NULL, mlx5_mprq_buf_init, NULL,
dev->device->numa_node, 0);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
2019-05-06 23:21 [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name Yongseok Koh
2019-05-06 23:21 ` Yongseok Koh
@ 2019-05-08 4:44 ` Shahaf Shuler
2019-05-08 4:44 ` Shahaf Shuler
1 sibling, 1 reply; 4+ messages in thread
From: Shahaf Shuler @ 2019-05-08 4:44 UTC (permalink / raw)
To: Yongseok Koh; +Cc: dev, stable
Tuesday, May 7, 2019 2:22 AM, Yongseok Koh:
> Subject: [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
>
> Currently, the name of MPRQ mempool is set by
> snprintf(name, sizeof(name), "%s-mprq", dev->device->name); For
> port representor, the name is duplicate of its master and failed to create
> such a mempool having the same name. Port ID is used in the name instead.
>
> Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
2019-05-08 4:44 ` Shahaf Shuler
@ 2019-05-08 4:44 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2019-05-08 4:44 UTC (permalink / raw)
To: Yongseok Koh; +Cc: dev, stable
Tuesday, May 7, 2019 2:22 AM, Yongseok Koh:
> Subject: [PATCH] net/mlx5: fix Multi-Packet RQ mempool name
>
> Currently, the name of MPRQ mempool is set by
> snprintf(name, sizeof(name), "%s-mprq", dev->device->name); For
> port representor, the name is duplicate of its master and failed to create
> such a mempool having the same name. Port ID is used in the name instead.
>
> Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-08 4:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 23:21 [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name Yongseok Koh
2019-05-06 23:21 ` Yongseok Koh
2019-05-08 4:44 ` Shahaf Shuler
2019-05-08 4:44 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).