* [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object
@ 2019-05-07 7:26 Dekel Peled
2019-05-07 7:26 ` Dekel Peled
2019-05-08 4:44 ` Shahaf Shuler
0 siblings, 2 replies; 4+ messages in thread
From: Dekel Peled @ 2019-05-07 7:26 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, stable
Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs
some actions on the returned rxq_ibv.
It doens't release the rxq_ibv when all is completed with success.
This patch adds call to mlx5_rxq_ibv_release() where it's missing.
Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0a4c02e..099c9e0 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -730,6 +730,7 @@
}
rxq_data->cq_arm_sn++;
mlx5_glue->ack_cq_events(rxq_ibv->cq, 1);
+ mlx5_rxq_ibv_release(rxq_ibv);
return 0;
exit:
ret = rte_errno; /* Save rte_errno before cleanup. */
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object
2019-05-07 7:26 [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object Dekel Peled
@ 2019-05-07 7:26 ` Dekel Peled
2019-05-08 4:44 ` Shahaf Shuler
1 sibling, 0 replies; 4+ messages in thread
From: Dekel Peled @ 2019-05-07 7:26 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, stable
Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs
some actions on the returned rxq_ibv.
It doens't release the rxq_ibv when all is completed with success.
This patch adds call to mlx5_rxq_ibv_release() where it's missing.
Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0a4c02e..099c9e0 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -730,6 +730,7 @@
}
rxq_data->cq_arm_sn++;
mlx5_glue->ack_cq_events(rxq_ibv->cq, 1);
+ mlx5_rxq_ibv_release(rxq_ibv);
return 0;
exit:
ret = rte_errno; /* Save rte_errno before cleanup. */
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object
2019-05-07 7:26 [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object Dekel Peled
2019-05-07 7:26 ` Dekel Peled
@ 2019-05-08 4:44 ` Shahaf Shuler
2019-05-08 4:44 ` Shahaf Shuler
1 sibling, 1 reply; 4+ messages in thread
From: Shahaf Shuler @ 2019-05-08 4:44 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh; +Cc: dev, stable
Tuesday, May 7, 2019 10:26 AM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue
> object
>
> Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some
> actions on the returned rxq_ibv.
> It doens't release the rxq_ibv when all is completed with success.
>
> This patch adds call to mlx5_rxq_ibv_release() where it's missing.
>
> Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue
> objects")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object
2019-05-08 4:44 ` Shahaf Shuler
@ 2019-05-08 4:44 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2019-05-08 4:44 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh; +Cc: dev, stable
Tuesday, May 7, 2019 10:26 AM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue
> object
>
> Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some
> actions on the returned rxq_ibv.
> It doens't release the rxq_ibv when all is completed with success.
>
> This patch adds call to mlx5_rxq_ibv_release() where it's missing.
>
> Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue
> objects")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-08 4:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 7:26 [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object Dekel Peled
2019-05-07 7:26 ` Dekel Peled
2019-05-08 4:44 ` Shahaf Shuler
2019-05-08 4:44 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).