From: Dekel Peled <dekelp@mellanox.com>
To: yskoh@mellanox.com, shahafs@mellanox.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer
Date: Wed, 8 May 2019 11:29:39 +0300 [thread overview]
Message-ID: <c8696aa941dba0adae0f7da58b4eb30700944b3c.1557303531.git.dekelp@mellanox.com> (raw)
Message-ID: <20190508082939.rtPrmPfVApw1s0-ZwOyIXepvIv14ppiYZzkv7qT-ulE@z> (raw)
In-Reply-To: <cover.1557303531.git.dekelp@mellanox.com>
Function mlx5_rxq_ibv_release() is called in several places.
Before each call except one, the input parameter is validated to make
sure it is not null.
This patch adds the validation where it is missing.
It also changes a priv_ prefix, left in a comment, to mlx5_ prefix.
Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxq.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 83ba525..f595e7a 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -593,11 +593,12 @@
continue;
/**
* Need to access directly the queue to release the reference
- * kept in priv_rx_intr_vec_enable().
+ * kept in mlx5_rx_intr_vec_enable().
*/
rxq_data = (*priv->rxqs)[i];
rxq_ctrl = container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);
- mlx5_rxq_ibv_release(rxq_ctrl->ibv);
+ if (rxq_ctrl->ibv)
+ mlx5_rxq_ibv_release(rxq_ctrl->ibv);
}
free:
rte_intr_free_epoll_fd(intr_handle);
--
1.8.3.1
next prev parent reply other threads:[~2019-05-08 8:36 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 11:00 [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 1/4] net/mlx5: remove unused functions Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 2/4] net/mlx5: add missing validation of null pointer Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-05-02 14:10 ` [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-02 14:10 ` Shahaf Shuler
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 " Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:14 ` Yongseok Koh
2019-05-02 18:14 ` Yongseok Koh
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-08 4:43 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-08 4:43 ` Shahaf Shuler
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 " Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` Dekel Peled [this message]
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-22 20:35 ` [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8696aa941dba0adae0f7da58b4eb30700944b3c.1557303531.git.dekelp@mellanox.com \
--to=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).