From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id A221FA0096
	for <public@inbox.dpdk.org>; Wed,  8 May 2019 11:37:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 728E53772;
	Wed,  8 May 2019 11:37:31 +0200 (CEST)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40])
 by dpdk.org (Postfix) with ESMTP id 282A22C2B
 for <dev@dpdk.org>; Wed,  8 May 2019 11:37:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IJ9HdCVbGzprtveIMrODxvxpHZu24eqxCabMne+wvaY=;
 b=HL9UC9vszOuZ3uDZM0gu7m8E5OqS82NrbKtHQyjv158H5RD0+x5fhuylyjduKOY2arveBrojrJFXJTdt1s8eh7tawD38p0IcJXuWe5hwy+F9v8sIWobq0m4NbsILxsuNulwazzCPj4YG8VPVjCftRdY0zIaS+ISC7/ikuqGBEl0=
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by
 DB3PR0502MB4009.eurprd05.prod.outlook.com (52.134.72.138) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1856.11; Wed, 8 May 2019 09:37:29 +0000
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1878.019; Wed, 8 May 2019
 09:37:29 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: dev <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Shahaf
 Shuler <shahafs@mellanox.com>, "Honnappa.Nagarahalli@arm.com"
 <Honnappa.Nagarahalli@arm.com>
Thread-Topic: [PATCH] doc: add Mellanox BlueField platform guide
Thread-Index: AQHVBUJZWlyUjlQ1akSbeMlss4aicqZg5VoAgAATbYA=
Date: Wed, 8 May 2019 09:37:28 +0000
Message-ID: <65BEC4F7-F9CE-49B8-82A3-57CAB91F8DD5@mellanox.com>
References: <20190508020400.37317-1-yskoh@mellanox.com>
 <3637602.VAhMH9uBB3@xps>
In-Reply-To: <3637602.VAhMH9uBB3@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=yskoh@mellanox.com; 
x-originating-ip: [69.181.245.183]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0eebfcdc-b909-4b35-034f-08d6d398c99c
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);
 SRVR:DB3PR0502MB4009; 
x-ms-traffictypediagnostic: DB3PR0502MB4009:
x-ms-exchange-purlcount: 1
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <DB3PR0502MB4009F98C999E0E783A868EBEC3320@DB3PR0502MB4009.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 0031A0FFAF
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(376002)(39860400002)(396003)(136003)(366004)(346002)(199004)(189003)(51914003)(83716004)(71190400001)(6116002)(66446008)(71200400001)(6916009)(73956011)(66946007)(66556008)(64756008)(76116006)(305945005)(7736002)(86362001)(316002)(256004)(486006)(478600001)(6436002)(6486002)(3846002)(2906002)(229853002)(5660300002)(36756003)(53546011)(11346002)(2616005)(6506007)(33656002)(446003)(91956017)(66476007)(76176011)(14454004)(25786009)(102836004)(6512007)(54906003)(68736007)(66066001)(4326008)(26005)(8936002)(476003)(81156014)(81166006)(6306002)(99286004)(82746002)(186003)(6246003)(8676002)(53936002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4009;
 H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: pnTL9NVK7oI4THo8wGHuupFtsrsDAI47NMjGbgD5bpCRr0L6jg/4HRPn9SefOYKkDfvHG1CHt0Ozh/gqIPmb654HWWwm/DIlVwVZfWLqZpEnsSz5u4jSKkUb6kOHAt+vAd9Up669us05T0Rfp7d26oJuPuyH7BiLRz8tdjCxaWSFQXH3AFb3W+PzIrjCi8S9YG77ohlpTzZl/KyoJ3xl9E6OJob2GB8z+/grd24ZvPRUU679RSXFHwotly8HvJLLKLPGUAl7Oc67M5CiiDkO0PkeokZRc0FZ5aTT5kljSxJrCeEgmi/aywbTTxSZ4hCQq40ZiH7OEEMz5yiqCobgehUfuf816G3sx6ObseN/mf0VgKOE00z8pKLO4sDdJLT7+a3FsIzPIqPqZaYXleCHhdd02pD4Th/yAASBoadrBW8=
Content-Type: text/plain; charset="UTF-8"
Content-ID: <26A803EA9B89724D908AE6AEAA7E16AC@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0eebfcdc-b909-4b35-034f-08d6d398c99c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 09:37:28.9637 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4009
Subject: Re: [dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190508093728.BWqO4sItVr7smfScUeuSTp5VHem9BUXxeb5S603GV1Q@z>

> On May 8, 2019, at 1:27 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>=20
> 08/05/2019 04:04, Yongseok Koh:
>> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
>> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
>> +.. _getting_the_prerequisite_library:
>=20
> The name of this anchor should specify "arm".
>=20
>> +
>> Getting the prerequisite library
>> --------------------------------
> [...]
>> --- /dev/null
>> +++ b/doc/guides/platform/bluefield.rst
>> +Toolchains, OS and drivers can be downloaded and installed individually=
 on the
>> +Web. But it is recommended to follow instructions at `Mellanox BlueFiel=
d
>> +Software Website <http://www.mellanox.com/page/products_dyn?product_fam=
ily=3D279&mtag=3Dbluefield_software>`_.
>=20
> Please split lines more often to avoid a line break in the middle
> of the link name.
>=20
> [...]
>> +Such required libraries can be cross-compiled and installed on to the c=
ross
>> +toolchain directory like depicted in :ref:`getting_the_prerequisite_lib=
rary`,
>> +but those can also be simply copied from the filesystem of a working Bl=
ueField
>> +platform. The following is to create such supplementary tarball on a Bl=
ueField
>> +platform.
>=20
> We are talking about cross-compilation?
> So we do the following commands on a x86 machine?
> I think I don't understand, it seems to be on BlueField.
> Please make it explicit below.
>=20
>> +.. code-block:: console
>> +
>> +        mkdir -p aarch64-linux-gnu/libc
>> +        pushd $PWD
>> +        cd aarch64-linux-gnu/libc
>> +
>> +        # Copy libraries
>> +        mkdir -p lib64
>> +        cp -a /lib64/libibverbs* lib64/
>> +        cp -a /lib64/libmnl* lib64/
>> +        cp -a /lib64/libmlx5* lib64/
>> +        cp -a /lib64/libnl-3* lib64/
>> +        cp -a /lib64/libnl-route-3* lib64/
>> +
>> +        # Copy header files
>> +        mkdir -p usr/include/infiniband
>> +        mkdir -p usr/include/libmnl
>> +        cp -a /usr/include/infiniband/ib_user_ioctl_verbs.h usr/include=
/infiniband/
>> +        cp -a /usr/include/infiniband/mlx5*.h usr/include/infiniband/
>> +        cp -a /usr/include/infiniband/tm_types.h usr/include/infiniband=
/
>> +        cp -a /usr/include/infiniband/verbs*.h usr/include/infiniband/
>> +        cp -a /usr/include/libmnl/libmnl.h usr/include/libmnl/
>> +
>> +        # Create supplementary tarball
>> +        popd
>> +        tar cf aarch64-linux-gnu-mlx.tar aarch64-linux-gnu/
>> +
>> +Then, untar the tarball at the cross toolchain directory on the x86 hos=
t.
>> +
>> +.. code-block:: console
>> +
>> +        cd $(dirname $(which aarch64-linux-gnu-gcc))/..
>> +        tar xf aarch64-linux-gnu-mlx.tar
>=20
> OK, this step is clearly on x86.
>=20
>> +- make build
>=20
> Should it be a sub-title instead of a list item?
>=20
>> +
>> +.. code-block:: console
>> +
>> +        make config T=3Darm64-bluefield-linuxapp-gcc
>> +        make -j CROSS=3Daarch64-linux-gnu- CONFIG_RTE_KNI_KMOD=3Dn CONF=
IG_RTE_EAL_IGB_UIO=3Dn
>> +
>> +- meson build
>> +
>> +.. code-block:: console
>> +
>> +        meson build --cross-file config/arm/arm64_bluefield_linux_gcc
>> +        ninja -C build
>=20
> [...]
>> --- a/doc/guides/rel_notes/release_19_05.rst
>> +++ b/doc/guides/rel_notes/release_19_05.rst
>> +* **Added new platform specific guide:**
>> +
>> +  * BlueField (Mellanox)
>=20
> I don't think a doc deserves to be in the release notes.

Thanks for the review, Thomas.
Will fix what you pointed out, all of them make sense to me.
I'm going to wait for another review (hopefully) and send out v2 soon.

Yongseok=