DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix queue interrupt for ICE
Date: Wed, 8 May 2019 11:37:51 +0100	[thread overview]
Message-ID: <d8ea24a1-acb8-5a4d-a6ce-c10f9f5fa3dc@redhat.com> (raw)
Message-ID: <20190508103751.RGwCF4OjDAHlmy95XmPwPEJOuGuvl4nELPkuLC61wlU@z> (raw)
In-Reply-To: <1555563495-47769-1-git-send-email-wei.zhao1@intel.com>

On 18/04/2019 05:58, Wei Zhao wrote:
> Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
> enable Tx and Rx queue interrupt.
> Also enable CLEARPBA bit does no impact on IAVF behaviour when be
> hosted by other devices, so we can make it as default.
> 
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")

The Fixes commit is in 18.11 stable but ice is not. If this is just for
ice as commit msg suggests, then it is not needed for 18.11 stable
branch. Please let me know if it's needed for some other reason on 18.11
branch.

thanks,
Kevin.

> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..57819dd 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
>  		PMD_DRV_LOG(INFO, "MISC is also enabled for control");
>  		IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01,
>  			      IAVFINT_DYN_CTL01_INTENA_MASK |
> +			      IAVFINT_DYN_CTL01_CLEARPBA_MASK |
>  			      IAVFINT_DYN_CTL01_ITR_INDX_MASK);
>  	} else {
>  		IAVF_WRITE_REG(hw,
>  			      IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START),
>  			      IAVFINT_DYN_CTLN1_INTENA_MASK |
> +			      IAVFINT_DYN_CTL01_CLEARPBA_MASK |
>  			      IAVFINT_DYN_CTLN1_ITR_INDX_MASK);
>  	}
>  
> 


  parent reply	other threads:[~2019-05-08 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18  4:58 [dpdk-dev] " Wei Zhao
2019-04-18  4:58 ` Wei Zhao
2019-04-18  8:10 ` Zhang, Qi Z
2019-04-18  8:10   ` Zhang, Qi Z
2019-05-08 10:37 ` Kevin Traynor [this message]
2019-05-08 10:37   ` [dpdk-dev] [dpdk-stable] " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8ea24a1-acb8-5a4d-a6ce-c10f9f5fa3dc@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).