From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D3B51A0096 for ; Wed, 8 May 2019 12:37:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BF8444C3; Wed, 8 May 2019 12:37:55 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CCAA23772; Wed, 8 May 2019 12:37:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2295830842B2; Wed, 8 May 2019 10:37:53 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A993611C3; Wed, 8 May 2019 10:37:51 +0000 (UTC) To: Wei Zhao , dev@dpdk.org Cc: stable@dpdk.org, qi.z.zhang@intel.com References: <1555563495-47769-1-git-send-email-wei.zhao1@intel.com> From: Kevin Traynor Message-ID: Date: Wed, 8 May 2019 11:37:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1555563495-47769-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 08 May 2019 10:37:53 +0000 (UTC) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix queue interrupt for ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508103751.RGwCF4OjDAHlmy95XmPwPEJOuGuvl4nELPkuLC61wlU@z> On 18/04/2019 05:58, Wei Zhao wrote: > Enable CLEARPBA bit is required by ice NIC of A0/A1 version to > enable Tx and Rx queue interrupt. > Also enable CLEARPBA bit does no impact on IAVF behaviour when be > hosted by other devices, so we can make it as default. > > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") The Fixes commit is in 18.11 stable but ice is not. If this is just for ice as commit msg suggests, then it is not needed for 18.11 stable branch. Please let me know if it's needed for some other reason on 18.11 branch. thanks, Kevin. > Cc: stable@dpdk.org > > Signed-off-by: Wei Zhao > --- > drivers/net/iavf/iavf_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c > index 846e604..57819dd 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id) > PMD_DRV_LOG(INFO, "MISC is also enabled for control"); > IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01, > IAVFINT_DYN_CTL01_INTENA_MASK | > + IAVFINT_DYN_CTL01_CLEARPBA_MASK | > IAVFINT_DYN_CTL01_ITR_INDX_MASK); > } else { > IAVF_WRITE_REG(hw, > IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START), > IAVFINT_DYN_CTLN1_INTENA_MASK | > + IAVFINT_DYN_CTL01_CLEARPBA_MASK | > IAVFINT_DYN_CTLN1_ITR_INDX_MASK); > } > >