From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3A93BA0096 for ; Wed, 8 May 2019 18:06:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E82B24C8D; Wed, 8 May 2019 18:06:46 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1C8643772; Wed, 8 May 2019 18:06:45 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F403C058CBD; Wed, 8 May 2019 16:06:44 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11791600C6; Wed, 8 May 2019 16:06:42 +0000 (UTC) To: Andrew Rybchenko , dev@dpdk.org Cc: Igor Romanov , stable@dpdk.org References: <1556007270-1511-1-git-send-email-arybchenko@solarflare.com> From: Kevin Traynor Message-ID: <7dafc0af-871f-0b7a-e4cc-797e8ac646ad@redhat.com> Date: Wed, 8 May 2019 17:06:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1556007270-1511-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 08 May 2019 16:06:44 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix MTU change to check Rx scatter consistency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508160642.33XxOayAbGrEp5OGrTjgNF7HttAjy5mh0SKaxNadFmc@z> On 23/04/2019 09:14, Andrew Rybchenko wrote: > From: Igor Romanov > > Rx queue setup function checks configured MTU to make sure that > no oversized packets can be received. But a following call to > set MTU function might make this check irrelevant. > > Add a function to check MTU size against Rx buffer size and > additional Rx queue info, including Rx scatter offload. > > Fixes: e961cf425e02 ("net/sfc: support MTU change") > Cc: stable@dpdk.org > Hi again - this one is causing a build failure on 18.11 branch. Please send a backport or let me know if it's not required. CC sfc_ethdev.o /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c: In function ‘sfc_check_scatter_on_all_rx_queues’: /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42: error: implicit declaration of function ‘sfc_sa2shared’; did you mean ‘sfc_stats_get’? [-Werror=implicit-function-declaration] struct sfc_adapter_shared * const sas = sfc_sa2shared(sa); ^~~~~~~~~~~~~ sfc_stats_get /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42: error: nested extern declaration of ‘sfc_sa2shared’ [-Werror=nested-externs] /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42: error: initialization of ‘struct sfc_adapter_shared * const’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:871:21: error: dereferencing pointer to incomplete type ‘struct sfc_adapter_shared’ for (i = 0; i < sas->rxq_count; i++) { ^~ /home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:878:38: error: ‘struct sfc_adapter’ has no member named ‘rxq_ctrl’; did you mean ‘rxq_max’? if (!sfc_rx_check_scatter(pdu, sa->rxq_ctrl[i].buf_size, ^~~~~~~~ rxq_max > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko