From: Stephen Hemminger <stephen@networkplumber.org>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup
Date: Wed, 8 May 2019 18:11:37 -0700 [thread overview]
Message-ID: <20190508181137.04112fd4@xps13> (raw)
In-Reply-To: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com>
On Wed, 8 May 2019 17:48:06 -0500
Erik Gabriel Carrillo <erik.g.carrillo@intel.com> wrote:
> Due to an upcoming fix to allow the timer library to safely free its
> allocations during the finalize() call[1], an ABI change will be
> required. A new lock will be added to the rte_mem_config structure,
> which will be used by the timer library to synchronize init/finalize
> calls among multiple processes.
>
> [1] http://patches.dpdk.org/patch/53334/
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b47c8c2..7551383 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -31,6 +31,10 @@ Deprecation Notices
>
> + ``rte_eal_devargs_type_count``
>
> +* eal: the ``rte_mem_config`` struct will change to include a new lock that
> + will allow the timer subsystem to safely release its allocations at cleanup
> + time. This will result in an ABI break.
> +
> * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
> have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
> functions. The due date for the removal targets DPDK 20.02.
NAK
Please go to the effort of making rte_mem_config not part of the visible ABI.
Then change it.
next prev parent reply other threads:[~2019-05-09 1:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 22:48 Erik Gabriel Carrillo
2019-05-08 22:48 ` Erik Gabriel Carrillo
2019-05-09 1:11 ` Stephen Hemminger [this message]
2019-05-09 1:11 ` Stephen Hemminger
2019-05-09 7:05 ` David Marchand
2019-05-09 7:05 ` David Marchand
2019-05-09 8:33 ` Burakov, Anatoly
2019-05-09 8:33 ` Burakov, Anatoly
2019-05-09 9:06 ` Bruce Richardson
2019-05-09 9:06 ` Bruce Richardson
2019-05-09 9:37 ` Burakov, Anatoly
2019-05-09 9:37 ` Burakov, Anatoly
2019-05-09 9:38 ` Thomas Monjalon
2019-05-09 9:38 ` Thomas Monjalon
2019-05-09 9:50 ` Ray Kinsella
2019-05-09 9:50 ` Ray Kinsella
2019-05-09 10:08 ` Burakov, Anatoly
2019-05-09 10:08 ` Burakov, Anatoly
2019-05-09 19:02 ` Stephen Hemminger
2019-05-09 19:02 ` Stephen Hemminger
2019-05-10 14:42 ` Stephen Hemminger
2019-05-10 14:42 ` Stephen Hemminger
2019-05-09 11:53 ` Burakov, Anatoly
2019-05-09 11:53 ` Burakov, Anatoly
2019-05-09 18:51 ` [dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config Erik Gabriel Carrillo
2019-05-09 18:51 ` Erik Gabriel Carrillo
2019-05-10 9:31 ` Burakov, Anatoly
2019-05-10 9:31 ` Burakov, Anatoly
2019-05-10 9:34 ` Bruce Richardson
2019-05-10 9:34 ` Bruce Richardson
2019-05-13 21:03 ` Thomas Monjalon
2019-05-13 21:03 ` Thomas Monjalon
2019-05-10 13:44 ` David Marchand
2019-05-10 13:44 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508181137.04112fd4@xps13 \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).