[dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[David Christensen]

Change "much" to "match" in a printf.

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
v2:
* None
v3:
* None

 app/test/test_barrier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c
index 82b572c..c219d56 100644
--- a/app/test/test_barrier.c
+++ b/app/test/test_barrier.c
@@ -252,7 +252,7 @@ struct lcore_plock_test {
 
 		/* race condition occurred, lock doesn't work properly */
 		if (sum[i] != pt[i].val || 2 * iter != pt[i].iter) {
-			printf("error: local and shared sums don't much\n");
+			printf("error: local and shared sums don't match\n");
 			rc = -1;
 		}
 	}
-- 
1.8.3.1

[dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[David Christensen]

Change "much" to "match" in a printf.

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
v2:
* None
v3:
* None

 app/test/test_barrier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c
index 82b572c..c219d56 100644
--- a/app/test/test_barrier.c
+++ b/app/test/test_barrier.c
@@ -252,7 +252,7 @@ struct lcore_plock_test {
 
 		/* race condition occurred, lock doesn't work properly */
 		if (sum[i] != pt[i].val || 2 * iter != pt[i].iter) {
-			printf("error: local and shared sums don't much\n");
+			printf("error: local and shared sums don't match\n");
 			rc = -1;
 		}
 	}
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

Hi David,

08/05/2019 23:02, David Christensen:
> v2:
> * None
> v3:
> * None

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread,
ideally with a cover letter.
All versions of a patchset must be in the same thread,
ideally with the cover letter v1 being the common ancestor.
Please check http://core.dpdk.org/contribute/#send

You need also to report the acks you got in previous versions.

Thanks

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

Hi David,

08/05/2019 23:02, David Christensen:
> v2:
> * None
> v3:
> * None

It seems your emails are not threaded at all.
It makes really hard to review them.
All patches of a patchset must be in the same thread,
ideally with a cover letter.
All versions of a patchset must be in the same thread,
ideally with the cover letter v1 being the common ancestor.
Please check http://core.dpdk.org/contribute/#send

You need also to report the acks you got in previous versions.

Thanks

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[David Christensen]

> It seems your emails are not threaded at all.
> It makes really hard to review them.
> All patches of a patchset must be in the same thread,
> ideally with a cover letter.
> All versions of a patchset must be in the same thread,
> ideally with the cover letter v1 being the common ancestor.
> Please check http://core.dpdk.org/contribute/#send
> 
> You need also to report the acks you got in previous versions.

I messed up with the first post in the patch series (no 0/4 message). In 
order to fix the long line problem, which post would you suggest I use 
as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
other?

Dave

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[David Christensen]

> It seems your emails are not threaded at all.
> It makes really hard to review them.
> All patches of a patchset must be in the same thread,
> ideally with a cover letter.
> All versions of a patchset must be in the same thread,
> ideally with the cover letter v1 being the common ancestor.
> Please check http://core.dpdk.org/contribute/#send
> 
> You need also to report the acks you got in previous versions.

I messed up with the first post in the patch series (no 0/4 message). In 
order to fix the long line problem, which post would you suggest I use 
as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
other?

Dave

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

09/05/2019 00:50, David Christensen:
> 
> > It seems your emails are not threaded at all.
> > It makes really hard to review them.
> > All patches of a patchset must be in the same thread,
> > ideally with a cover letter.
> > All versions of a patchset must be in the same thread,
> > ideally with the cover letter v1 being the common ancestor.
> > Please check http://core.dpdk.org/contribute/#send
> > 
> > You need also to report the acks you got in previous versions.
> 
> I messed up with the first post in the patch series (no 0/4 message). In 
> order to fix the long line problem, which post would you suggest I use 
> as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
> other?

The patches of v3 are not threaded together,
so when doing a v4 you can skip --in-reply-to.

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

09/05/2019 00:50, David Christensen:
> 
> > It seems your emails are not threaded at all.
> > It makes really hard to review them.
> > All patches of a patchset must be in the same thread,
> > ideally with a cover letter.
> > All versions of a patchset must be in the same thread,
> > ideally with the cover letter v1 being the common ancestor.
> > Please check http://core.dpdk.org/contribute/#send
> > 
> > You need also to report the acks you got in previous versions.
> 
> I messed up with the first post in the patch series (no 0/4 message). In 
> order to fix the long line problem, which post would you suggest I use 
> as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
> other?

The patches of v3 are not threaded together,
so when doing a v4 you can skip --in-reply-to.

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

09/05/2019 09:46, Thomas Monjalon:
> 09/05/2019 00:50, David Christensen:
> > > It seems your emails are not threaded at all.
> > > It makes really hard to review them.
> > > All patches of a patchset must be in the same thread,
> > > ideally with a cover letter.
> > > All versions of a patchset must be in the same thread,
> > > ideally with the cover letter v1 being the common ancestor.
> > > Please check http://core.dpdk.org/contribute/#send
> > > 
> > > You need also to report the acks you got in previous versions.
> > 
> > I messed up with the first post in the patch series (no 0/4 message). In 
> > order to fix the long line problem, which post would you suggest I use 
> > as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
> > other?
> 
> The patches of v3 are not threaded together,
> so when doing a v4 you can skip --in-reply-to.

Series applied with added acks, fixes lines, etc, thanks.

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

[Thomas Monjalon]

09/05/2019 09:46, Thomas Monjalon:
> 09/05/2019 00:50, David Christensen:
> > > It seems your emails are not threaded at all.
> > > It makes really hard to review them.
> > > All patches of a patchset must be in the same thread,
> > > ideally with a cover letter.
> > > All versions of a patchset must be in the same thread,
> > > ideally with the cover letter v1 being the common ancestor.
> > > Please check http://core.dpdk.org/contribute/#send
> > > 
> > > You need also to report the acks you got in previous versions.
> > 
> > I messed up with the first post in the patch series (no 0/4 message). In 
> > order to fix the long line problem, which post would you suggest I use 
> > as an anchor for my reply-to?  The original v1 1/4, the v3 1/4, or some 
> > other?
> 
> The patches of v3 are not threaded together,
> so when doing a v4 you can skip --in-reply-to.

Series applied with added acks, fixes lines, etc, thanks.