From: Nikhil Rao <nikhil.rao@intel.com>
To: jerinj@marvell.com
Cc: dev@dpdk.org, matias.elo@nokia.com, Nikhil Rao <nikhil.rao@intel.com>
Subject: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic
Date: Thu, 9 May 2019 10:20:40 +0530 [thread overview]
Message-ID: <1557377440-11616-1-git-send-email-nikhil.rao@intel.com> (raw)
Message-ID: <20190509045040.TKUP6vzRajIgRRaIjnuFsf1Aw_8AJxyBF_V5FcNfhjg@z> (raw)
In-Reply-To: <1557376797-10609-1-git-send-email-nikhil.rao@intel.com>
The Rx adapter flushes events only if it has BATCH_SIZE
events buffered where BATCH_SIZE is set to 32, e.g., if a
single packet is sent, it is never passed to
eventdev. Fix this issue by adding an event buffer flush
either when a Rx queue is found to be empty or the adapter service
function has processed the max number of packets for an invocation.
Bugzilla ID: 277
Fixes: 6b83f5935543 ("eventdev: add event buffer flush in Rx adapter")
Reported-by: Matias Elo <matias.elo@nokia.com>
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2:
* added Bugzilla ID
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8d178be..fd3761b 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -872,7 +872,7 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
break;
}
- if (buf->count >= BATCH_SIZE)
+ if (buf->count)
rxa_flush_event_buffer(rx_adapter);
return nb_rx;
--
1.8.3.1
next prev parent reply other threads:[~2019-05-09 11:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 4:39 [dpdk-dev] [PATCH] " Nikhil Rao
2019-05-09 4:39 ` Nikhil Rao
2019-05-09 4:50 ` Nikhil Rao [this message]
2019-05-09 4:50 ` [dpdk-dev] [PATCH v2] " Nikhil Rao
2019-05-09 19:17 ` Thomas Monjalon
2019-05-09 19:17 ` Thomas Monjalon
2019-05-09 19:23 ` Mattias Rönnblom
2019-05-09 19:23 ` Mattias Rönnblom
2019-05-10 8:19 ` Rao, Nikhil
2019-05-10 8:19 ` Rao, Nikhil
2019-05-09 19:22 ` Mattias Rönnblom
2019-05-09 19:22 ` Mattias Rönnblom
2019-05-10 8:20 ` Rao, Nikhil
2019-05-10 8:20 ` Rao, Nikhil
2019-05-10 8:08 ` [dpdk-dev] [PATCH v3] " Nikhil Rao
2019-05-10 8:08 ` Nikhil Rao
2019-05-10 13:30 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-10 13:30 ` Thomas Monjalon
2019-05-10 16:13 ` Mattias Rönnblom
2019-05-10 16:13 ` Mattias Rönnblom
2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
2019-05-13 14:00 ` Thomas Monjalon
2019-05-13 14:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557377440-11616-1-git-send-email-nikhil.rao@intel.com \
--to=nikhil.rao@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=matias.elo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).