DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, yuan.peng@intel.com, ferruh.yigit@intel.com,
	wenzhuo.lu@intel.com, Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: remove port stop check for macsec
Date: Thu,  9 May 2019 15:20:26 +0800	[thread overview]
Message-ID: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> (raw)
Message-ID: <20190509072026.mf39Y9yzQHfYOpDCpMSex-ASjXTUvckhMGb1x-OkPYc@z> (raw)

There is no need to do such a check when set macsec for ixgbe,
reconfig_device_queueand is also useless. If ew do not delete this
unnessarycode, users have to sotp port before enable macsec, then
restart this port after make configuration. All these process is
useless. As this cmdline is a private API only use by ixgbe NIC,
so remove it.

Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 app/test-pmd/cmdline.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c1042dd..b969745 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
 		return;
-	if (!port_is_stopped(port_id)) {
-		printf("Please stop port %d first\n", port_id);
-		return;
-	}
 
 	rte_eth_dev_info_get(port_id, &dev_info);
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
 	case 0:
 		ports[port_id].dev_conf.txmode.offloads |=
 						DEV_TX_OFFLOAD_MACSEC_INSERT;
-		cmd_reconfig_device_queue(port_id, 1, 1);
 		break;
 	case -ENODEV:
 		printf("invalid port_id %d\n", port_id);
-- 
2.7.5


             reply	other threads:[~2019-05-09  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:20 Wei Zhao [this message]
2019-05-09  7:20 ` Wei Zhao
2019-05-10  8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10  8:41   ` Wei Zhao
2019-05-13  3:30   ` Zhao1, Wei
2019-05-13  3:30     ` Zhao1, Wei
2019-06-07 13:59     ` Iremonger, Bernard
2019-06-10  6:40       ` Zhao1, Wei
2019-06-10  6:07   ` [dpdk-dev] [PATCH v3] " Wei Zhao
2019-06-27 17:23     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-06-30 21:50       ` Thomas Monjalon
2019-07-01 16:39         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557386426-57149-1-git-send-email-wei.zhao1@intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).