From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 83822A0096 for ; Thu, 9 May 2019 09:49:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF0A64D27; Thu, 9 May 2019 09:49:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 327292C2B; Thu, 9 May 2019 09:49:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:49:20 -0700 X-ExtLoop1: 1 Received: from dpdk6.bj.intel.com ([172.16.182.192]) by orsmga001.jf.intel.com with ESMTP; 09 May 2019 00:49:18 -0700 From: Wei Zhao To: dev@dpdk.org Cc: stable@dpdk.org, yuan.peng@intel.com, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, Wei Zhao Date: Thu, 9 May 2019 15:20:26 +0800 Message-Id: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 Subject: [dpdk-dev] [PATCH] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190509072026.mf39Y9yzQHfYOpDCpMSex-ASjXTUvckhMGb1x-OkPYc@z> There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If ew do not delete this unnessarycode, users have to sotp port before enable macsec, then restart this port after make configuration. All these process is useless. As this cmdline is a private API only use by ixgbe NIC, so remove it. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- app/test-pmd/cmdline.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c1042dd..b969745 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed( case 0: ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); -- 2.7.5