From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: Arnon Warshavsky <arnon@qwilt.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
Date: Thu, 09 May 2019 09:38:35 +0200 [thread overview]
Message-ID: <3927594.Gl3vgMmjsF@xps> (raw)
Message-ID: <20190509073835.DpEbCurvCAFvT9nrpdmTdafDx77CtgiqQmUKGZafSQs@z> (raw)
In-Reply-To: <CAJFAV8zOPipG_jy_d0xE61JeC2SZdivTJSHacjQaU4OsJQBAZA@mail.gmail.com>
09/05/2019 09:34, David Marchand:
> On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> > + after read or write error on the pipe, instead of calling ``rte_panic``.
> > +
> >
>
> Nit: do we need error codes ? or only a single new error code ?
That's something to discuss.
In my opinion, we should return any errno from read and write syscalls:
return -errno;
next prev parent reply other threads:[~2019-05-09 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 20:54 Thomas Monjalon
2019-05-08 20:54 ` Thomas Monjalon
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-13 20:54 ` Thomas Monjalon
2019-05-13 20:54 ` Thomas Monjalon
2019-05-09 7:34 ` David Marchand
2019-05-09 7:34 ` David Marchand
2019-05-09 7:38 ` Thomas Monjalon [this message]
2019-05-09 7:38 ` Thomas Monjalon
2019-05-09 14:55 ` Ferruh Yigit
2019-05-09 14:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3927594.Gl3vgMmjsF@xps \
--to=thomas@monjalon.net \
--cc=arnon@qwilt.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).