From: Thomas Monjalon <thomas@monjalon.net>
To: 胡林帆 <zhongdahulinfan@163.com>
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>,
stable@dpdk.org, Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
dev@dpdk.org, honnappa.nagarahalli@arm.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position'
Date: Thu, 09 May 2019 13:25:38 +0200 [thread overview]
Message-ID: <3714892.DAfdNftnfW@xps> (raw)
Message-ID: <20190509112538.NmO_k7FoUF-IiibCcXSkT4trE0hlXwLS8GY3h0Hw29w@z> (raw)
In-Reply-To: <23fbf768.fdd0.16a9c2dda1e.Coremail.zhongdahulinfan@163.com>
09/05/2019 12:40, 胡林帆:
> This bug makes 'lock free reader/writer concurrency hash' unusable.
> There are two reasons:
> 1] memory leak because we cannot free keys which indexes greater than the number of total entries
>
> 2] the ring of free_slots may have unexpected key conflict with in use one
>
> The patch fixes these 2 issues, both of which are in the same API:
>
> int __rte_experimental
> rte_hash_free_key_with_position(const struct rte_hash *h,
> const int32_t position)
>
> I don't think it is necessarily to split in 2 patches.
Sorry for insisting, I think it is necessary to split in 2 patches
with better explanations in the commit logs.
Then we'll need approval from the maintainers.
PS1: Please provide your full name in english alphabet
PS2: Please do not top-post
> At 2019-05-09 16:29:56, "Thomas Monjalon" <thomas@monjalon.net> wrote:
> >09/05/2019 00:59, Dharmik Thakkar:
> >> This patch fixes 2 bugs-
> >> 1] Incorrect position returned to the free slots.
> >> 2] Incorrect computation of total_entries
> >
> >Is it possible to split in 2 patches?
> >
> >How critical is this bug? It looks old.
> >I'm afraid it will miss 19.05.
next prev parent reply other threads:[~2019-05-09 11:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 16:51 [dpdk-dev] [PATCH 0/2] " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 1/2] " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 0/2] hash: fix bugs in " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 1/2] " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 8:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 8:29 ` Thomas Monjalon
2019-05-09 10:40 ` 胡林帆
2019-05-09 10:40 ` 胡林帆
2019-05-09 11:25 ` Thomas Monjalon [this message]
2019-05-09 11:25 ` Thomas Monjalon
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 20:23 ` Thomas Monjalon
2019-05-09 20:30 ` Dharmik Thakkar
2019-05-09 20:30 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:24 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Thomas Monjalon
2019-05-09 19:24 ` Thomas Monjalon
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 20:36 ` Thomas Monjalon
2019-05-09 20:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3714892.DAfdNftnfW@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
--cc=zhongdahulinfan@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).